Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top level order #739

Merged
merged 16 commits into from
Feb 5, 2021
Merged

Top level order #739

merged 16 commits into from
Feb 5, 2021

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Jan 31, 2021

What's done:

Implemented rule, added tests and documentations

Actions checklist

### What's done:
   Implemented rule, added tests and documentations
@kentr0w kentr0w added the enhancement New feature or request label Jan 31, 2021
@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #739 (13d11ea) into master (dfe0e4a) will increase coverage by 0.12%.
The diff coverage is 84.41%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #739      +/-   ##
============================================
+ Coverage     79.63%   79.75%   +0.12%     
- Complexity     2003     2016      +13     
============================================
  Files            96       97       +1     
  Lines          5032     5074      +42     
  Branches       1604     1621      +17     
============================================
+ Hits           4007     4047      +40     
  Misses          246      246              
- Partials        779      781       +2     
Flag Coverage Δ Complexity Δ
unittests 79.75% <84.41%> (+0.12%) 0.00 <13.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...at-rules/src/main/kotlin/generated/WarningNames.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/constants/Chapters.kt 60.86% <0.00%> (ø) 2.00 <0.00> (ø)
...fn/diktat/common/config/rules/RulesConfigReader.kt 41.46% <33.33%> (ø) 4.00 <0.00> (ø)
...cqfn/diktat/ruleset/utils/PositionInTextLocator.kt 83.33% <78.57%> (ø) 0.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 81.48% <81.81%> (+0.15%) 0.00 <0.00> (ø)
.../ruleset/rules/chapter3/files/TopLevelOrderRule.kt 94.73% <94.73%> (ø) 13.00 <13.00> (?)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 97.82% <100.00%> (+0.01%) 12.00 <0.00> (ø)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 93.57% <100.00%> (+0.05%) 11.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/utils/AstConstants.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...n/org/cqfn/diktat/ruleset/utils/StringCaseUtils.kt 84.00% <100.00%> (ø) 0.00 <0.00> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe0e4a...13d11ea. Read the comment docs.

### What's done:
   Fixed according to our code style
# Conflicts:
#	diktat-common/src/main/kotlin/org/cqfn/diktat/common/config/rules/RulesConfigReader.kt
### What's done:
   Fixed according to our code style
### What's done:
   Fixed bug
### What's done:
   Fixed wrong order
### What's done:
   Fixed according to our code style
### What's done:
   Fixed according to our code style
### What's done:
   Fixed according to our code style
### What's done:
   Fixed according to our code style
### What's done:
   Fixed according to our code style
Copy link
Collaborator

@aktsay6 aktsay6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above

### What's done:
   Fixed after review
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

### What's done:
   Fixed according to our code style
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, lgtm

### What's done:
   Fixed according to our code style
@kentr0w kentr0w merged commit f652657 into master Feb 5, 2021
@kentr0w kentr0w deleted the feature/rule-3.1.5 branch February 5, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule 3.1.5: Order of declaration of top-level code structures
3 participants