-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top level order #739
Top level order #739
Conversation
### What's done: Implemented rule, added tests and documentations
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
============================================
+ Coverage 79.63% 79.75% +0.12%
- Complexity 2003 2016 +13
============================================
Files 96 97 +1
Lines 5032 5074 +42
Branches 1604 1621 +17
============================================
+ Hits 4007 4047 +40
Misses 246 246
- Partials 779 781 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: Fixed according to our code style
# Conflicts: # diktat-common/src/main/kotlin/org/cqfn/diktat/common/config/rules/RulesConfigReader.kt
### What's done: Fixed according to our code style
### What's done: Fixed bug
### What's done: Fixed wrong order
### What's done: Fixed according to our code style
### What's done: Fixed according to our code style
### What's done: Fixed according to our code style
### What's done: Fixed according to our code style
### What's done: Fixed according to our code style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/TopLevelOrderRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/TopLevelOrderRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/TopLevelOrderRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/TopLevelOrderRule.kt
Show resolved
Hide resolved
### What's done: Fixed after review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/TopLevelOrderRule.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed after review
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/TopLevelOrderRule.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed according to our code style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, lgtm
### What's done: Fixed according to our code style
What's done:
Implemented rule, added tests and documentations
Actions checklist