Disable chapters #718
Merged
Disable chapters #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: Added parameter
### What's done: Fixed rule-mapping parser
### What's done: Fixed according our code-style
orchestr7
reviewed
Jan 20, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Chapter.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #718 +/- ##
============================================
- Coverage 80.12% 80.00% -0.13%
- Complexity 1944 1947 +3
============================================
Files 92 93 +1
Lines 4982 5007 +25
Branches 1595 1606 +11
============================================
+ Hits 3992 4006 +14
- Misses 241 245 +4
- Partials 749 756 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
orchestr7
reviewed
Jan 20, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Chapter.kt
Outdated
Show resolved
Hide resolved
orchestr7
reviewed
Jan 20, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Chapter.kt
Outdated
Show resolved
Hide resolved
orchestr7
reviewed
Jan 20, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Chapter.kt
Outdated
Show resolved
Hide resolved
orchestr7
reviewed
Jan 20, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Chapter.kt
Outdated
Show resolved
Hide resolved
orchestr7
reviewed
Jan 20, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt
Outdated
Show resolved
Hide resolved
orchestr7
reviewed
Jan 20, 2021
orchestr7
requested changes
Jan 20, 2021
### What's done: Fixed after review
### What's done: Fixed according our code-style
### What's done: Fixed according our code-style
### What's done: Fixed according our code-style
petertrr
requested changes
Jan 25, 2021
diktat-common/src/main/kotlin/org/cqfn/diktat/common/config/rules/RulesConfigReader.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Chapters.kt
Outdated
Show resolved
Hide resolved
diktat-common/src/main/kotlin/org/cqfn/diktat/common/config/rules/RulesConfigReader.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Chapters.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/smoke/DiktatSmokeTest.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed after review
### What's done: Fixed after review
…hapter # Conflicts: # diktat-rules/src/main/kotlin/generated/WarningNames.kt
### What's done: Fixed according our code-style
petertrr
approved these changes
Jan 26, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Chapters.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed after review
petertrr
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parametr to disable chapters in config
closes #204