Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable chapters #718

Merged
merged 13 commits into from
Jan 27, 2021
Merged

Disable chapters #718

merged 13 commits into from
Jan 27, 2021

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Jan 20, 2021

Added parametr to disable chapters in config
closes #204

### What's done:
   Added parameter
### What's done:
   Fixed rule-mapping parser
@kentr0w kentr0w added the enhancement New feature or request label Jan 20, 2021
### What's done:
   Fixed according our code-style
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #718 (f016bc7) into master (05c3ebb) will decrease coverage by 0.12%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #718      +/-   ##
============================================
- Coverage     80.12%   80.00%   -0.13%     
- Complexity     1944     1947       +3     
============================================
  Files            92       93       +1     
  Lines          4982     5007      +25     
  Branches       1595     1606      +11     
============================================
+ Hits           3992     4006      +14     
- Misses          241      245       +4     
- Partials        749      756       +7     
Flag Coverage Δ Complexity Δ
unittests 80.00% <55.55%> (-0.13%) 0.00 <7.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...fn/diktat/common/config/rules/RulesConfigReader.kt 29.03% <0.00%> (-2.01%) 4.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 97.76% <50.00%> (ø) 12.00 <5.00> (+1.00)
...tlin/org/cqfn/diktat/ruleset/constants/Chapters.kt 60.86% <60.86%> (ø) 2.00 <2.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c3ebb...f016bc7. Read the comment docs.

Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the logic for a table generation (rules-mapping)?

### What's done:
   Fixed after review
### What's done:
   Fixed according our code-style
### What's done:
   Fixed according our code-style
### What's done:
   Fixed according our code-style
### What's done:
   Fixed after review
### What's done:
   Fixed after review
…hapter

# Conflicts:
#	diktat-rules/src/main/kotlin/generated/WarningNames.kt
### What's done:
   Fixed according our code-style
### What's done:
   Fixed after review
Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit 5dd1394 into master Jan 27, 2021
@petertrr petertrr deleted the feature/enable-by-chapter branch January 27, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diktat should be able to disable groups of warnings by one click (by chapters for examples)
3 participants