Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix with gradle plugin config #706

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Jan 14, 2021

Gradle file API returns absolute paths relative to project's directory, so no need to check whether it's absolute. Need to use proper way to specify path in build.gradle instead.
Added more tests.

What's done:

  • Fixes & tests

This pull request closes #703

### What's done:
* Functional tests for groovy DSL
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #706 (00e6bda) into master (b43fb71) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #706      +/-   ##
============================================
+ Coverage     80.10%   80.13%   +0.02%     
- Complexity     1894     1895       +1     
============================================
  Files            90       90              
  Lines          4912     4912              
  Branches       1575     1575              
============================================
+ Hits           3935     3936       +1     
+ Misses          239      238       -1     
  Partials        738      738              
Flag Coverage Δ Complexity Δ
unittests 80.13% <100.00%> (+0.02%) 0.00 <3.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...n/org/cqfn/diktat/plugin/gradle/DiktatExtension.kt 100.00% <100.00%> (ø) 7.00 <1.00> (+1.00)
...rg/cqfn/diktat/plugin/gradle/DiktatGradlePlugin.kt 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 92.98% <100.00%> (+1.75%) 17.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b43fb71...00e6bda. Read the comment docs.

Copy link
Collaborator

@aktsay6 aktsay6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit 9eefb12 into master Jan 19, 2021
@petertrr petertrr deleted the bugfix/gradle-plugin-onfig-resolving#703 branch January 19, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In gradle plugin, should check if config file is relative to current project dir
2 participants