Feature. Auto-fixes for null-checks #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Added fix tests * Added fix logic
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
============================================
- Coverage 80.00% 79.99% -0.01%
- Complexity 1824 1835 +11
============================================
Files 87 87
Lines 4735 4769 +34
Branches 1527 1540 +13
============================================
+ Hits 3788 3815 +27
+ Misses 239 238 -1
- Partials 708 716 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Fixed bugs
petertrr
requested changes
Dec 30, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/NullChecksRule.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
### What's done: * Fixed bugs
petertrr
approved these changes
Dec 31, 2020
| "use 'requireNotNull' instead of require(${condition.text})" | ||
| ) { | ||
| // todo implement fixer | ||
| val variableName = binaryExprNode.firstChildNode.text |
There was a problem hiding this comment.
Will firstChildNode always be the needed one here? Maybe, psi.getLeft() will be more reliable?
### What's done: * Fixed bugs
### What's done: * Fixed bugs
### What's done: * Fixed bugs
### What's done: * Fixed bugs
### What's done: * Fixed bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #538