Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix in AnnotationNewLineRule #662

Merged
merged 7 commits into from
Dec 25, 2020
Merged

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Dec 22, 2020

What's done:

Fixed bug

closes #657

### What's done:
    Fixed bug
@kentr0w kentr0w added the bug Something isn't working label Dec 22, 2020
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #662 (aeed685) into master (ee08aa4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #662      +/-   ##
============================================
- Coverage     79.26%   79.24%   -0.02%     
+ Complexity     1804     1803       -1     
============================================
  Files            87       87              
  Lines          4706     4708       +2     
  Branches       1511     1513       +2     
============================================
+ Hits           3730     3731       +1     
  Misses          280      280              
- Partials        696      697       +1     
Flag Coverage Δ Complexity Δ
unittests 79.24% <100.00%> (-0.02%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...cqfn/diktat/ruleset/rules/AnnotationNewLineRule.kt 86.36% <100.00%> (ø) 14.00 <0.00> (-1.00)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 81.09% <100.00%> (-0.27%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee08aa4...aeed685. Read the comment docs.

### What's done:
    Fixed according our code style
### What's done:
    Fixed according our code style
### What's done:
    Fixed after review
### What's done:
    Fixed according our code style
@kentr0w kentr0w merged commit 26c838e into master Dec 25, 2020
@kentr0w kentr0w deleted the bugfix/annotation-new-line-fix branch December 25, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANNOTATION_NEW_LINE doesn't trigger if the annotation doesn't start on a new line
2 participants