Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. A lot of FP LOCAL_VARIABLE_EARLY_DECLARATION #642

Merged
merged 9 commits into from
Dec 16, 2020

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Dec 14, 2020

What's done:

  • Fixed bugs

This pull request closes #589

### What's done:
  * Fixed bugs
@aktsay6 aktsay6 added the bug Something isn't working label Dec 14, 2020
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #642 (19fdc50) into master (0728f36) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #642      +/-   ##
============================================
+ Coverage     80.73%   80.77%   +0.04%     
+ Complexity     1790     1789       -1     
============================================
  Files            90       90              
  Lines          4702     4718      +16     
  Branches       1423     1424       +1     
============================================
+ Hits           3796     3811      +15     
  Misses          321      321              
- Partials        585      586       +1     
Flag Coverage Δ Complexity Δ
unittests 80.77% <100.00%> (+0.04%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...kotlin/org/cqfn/diktat/ruleset/rules/LineLength.kt 84.05% <100.00%> (ø) 74.00 <0.00> (ø)
...at/ruleset/rules/identifiers/LocalVariablesRule.kt 91.30% <100.00%> (+0.51%) 24.00 <0.00> (-1.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0728f36...19fdc50. Read the comment docs.

### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
@aktsay6 aktsay6 marked this pull request as ready for review December 15, 2020 13:25
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
@aktsay6 aktsay6 merged commit e38ee59 into master Dec 16, 2020
@aktsay6 aktsay6 deleted the bugfix/fp-local-variable(#589) branch December 16, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A lot of FP LOCAL_VARIABLE_EARLY_DECLARATION
2 participants