-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix. FP of LOCAL_VARIABLE_EARLY_DECLARATION with other variables and a loop #635
Conversation
### What's done: * Fixed bugs * Added tests
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
============================================
- Coverage 80.83% 80.83% -0.01%
- Complexity 1774 1775 +1
============================================
Files 90 90
Lines 4670 4680 +10
Branches 1408 1410 +2
============================================
+ Hits 3775 3783 +8
- Misses 317 318 +1
- Partials 578 579 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Fixed bugs * Added tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have several suppressed LOCAL_VARIABLE_EARLY_DECLARATION
in our code, please find the ones that will be fixed by your change and un-suppress them
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/LocalVariablesWarnTest.kt
Show resolved
Hide resolved
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/LocalVariablesWarnTest.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/identifiers/LocalVariablesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/identifiers/LocalVariablesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/identifiers/LocalVariablesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/identifiers/LocalVariablesRule.kt
Show resolved
Hide resolved
### What's done: * Fixed bugs
### What's done: * Fixed bugs
### What's done: * Fixed bugs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's done:
This pull request closes #581