Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. FP of LOCAL_VARIABLE_EARLY_DECLARATION with other variables and a loop #635

Merged
merged 6 commits into from
Dec 14, 2020

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Dec 10, 2020

What's done:

  • Fixed bugs
  • Added tests

This pull request closes #581

### What's done:
 * Fixed bugs
 * Added tests
@aktsay6 aktsay6 added the bug Something isn't working label Dec 10, 2020
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #635 (4cabf6d) into master (4edbd78) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #635      +/-   ##
============================================
- Coverage     80.83%   80.83%   -0.01%     
- Complexity     1774     1775       +1     
============================================
  Files            90       90              
  Lines          4670     4680      +10     
  Branches       1408     1410       +2     
============================================
+ Hits           3775     3783       +8     
- Misses          317      318       +1     
- Partials        578      579       +1     
Flag Coverage Δ Complexity Δ
unittests 80.83% <85.71%> (-0.01%) 0.00 <2.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...at/ruleset/rules/ExtensionFunctionsSameNameRule.kt 88.88% <ø> (ø) 18.00 <0.00> (ø)
...kotlin/org/cqfn/diktat/ruleset/rules/LineLength.kt 84.05% <ø> (ø) 74.00 <0.00> (ø)
...lin/org/cqfn/diktat/ruleset/rules/SmartCastRule.kt 64.16% <ø> (ø) 36.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 84.82% <ø> (ø) 0.00 <0.00> (ø)
...at/ruleset/rules/identifiers/LocalVariablesRule.kt 90.78% <84.61%> (-1.64%) 25.00 <2.00> (+1.00) ⬇️
...n/kotlin/org/cqfn/diktat/ruleset/rules/SortRule.kt 86.76% <100.00%> (ø) 23.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4edbd78...4cabf6d. Read the comment docs.

### What's done:
 * Fixed bugs
 * Added tests
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have several suppressed LOCAL_VARIABLE_EARLY_DECLARATION in our code, please find the ones that will be fixed by your change and un-suppress them

### What's done:
 * Fixed bugs
@aktsay6 aktsay6 marked this pull request as draft December 11, 2020 08:43
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
@aktsay6 aktsay6 marked this pull request as ready for review December 14, 2020 09:17
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aktsay6 aktsay6 merged commit c1c8d2d into master Dec 14, 2020
@aktsay6 aktsay6 deleted the bugfix/local-variable-loops(#581) branch December 14, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FP of LOCAL_VARIABLE_EARLY_DECLARATION with other variables and a loop
2 participants