Fixing diktat-gradle-plugin #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Introduced functional tests for diktat-gradle-plugin
### What's done: * WIP
### What's done: * WIP
### What's done: * WIP
### What's done: * Respect skipTests in diktat-gradle-plugin build
### What's done: * Run task functionalTest after test * Manually relativize file paths
### What's done: * Do not use quotes in patterns * Run gradle daemon in CI builds
### What's done: * Improved functional tests
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
============================================
+ Coverage 80.76% 80.78% +0.02%
- Complexity 1748 1750 +2
============================================
Files 89 89
Lines 4612 4612
Branches 1391 1391
============================================
+ Hits 3725 3726 +1
+ Misses 320 318 -2
- Partials 567 568 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kentr0w
approved these changes
Dec 10, 2020
diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt
Show resolved
Hide resolved
.../src/functionalTest/kotlin/org/cqfn/diktat/plugin/gradle/DiktatGradlePluginFunctionalTest.kt
Show resolved
Hide resolved
### What's done: * Jacoco test coverage in functionalTest
### What's done: * Jacoco test coverage in functionalTest
aktsay6
approved these changes
Dec 10, 2020
.../src/functionalTest/kotlin/org/cqfn/diktat/plugin/gradle/DiktatGradlePluginFunctionalTest.kt
Show resolved
Hide resolved
### What's done: * Jacoco test coverage in functionalTest
### What's done: * Jacoco test coverage in functionalTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
-DskipTests=trueThis pull request closes #627