-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing diktat-gradle-plugin #628
Conversation
### What's done: * Introduced functional tests for diktat-gradle-plugin
### What's done: * WIP
### What's done: * WIP
### What's done: * WIP
### What's done: * Respect skipTests in diktat-gradle-plugin build
### What's done: * Run task functionalTest after test * Manually relativize file paths
### What's done: * Do not use quotes in patterns * Run gradle daemon in CI builds
### What's done: * Improved functional tests
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
============================================
+ Coverage 80.76% 80.78% +0.02%
- Complexity 1748 1750 +2
============================================
Files 89 89
Lines 4612 4612
Branches 1391 1391
============================================
+ Hits 3725 3726 +1
+ Misses 320 318 -2
- Partials 567 568 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but a few questions to clarify
diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt
Show resolved
Hide resolved
.../src/functionalTest/kotlin/org/cqfn/diktat/plugin/gradle/DiktatGradlePluginFunctionalTest.kt
Show resolved
Hide resolved
### What's done: * Jacoco test coverage in functionalTest
### What's done: * Jacoco test coverage in functionalTest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
.../src/functionalTest/kotlin/org/cqfn/diktat/plugin/gradle/DiktatGradlePluginFunctionalTest.kt
Show resolved
Hide resolved
### What's done: * Jacoco test coverage in functionalTest
### What's done: * Jacoco test coverage in functionalTest
What's done:
-DskipTests=true
This pull request closes #627