Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for diktat-maven-plugin #607

Merged
merged 9 commits into from
Dec 7, 2020

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Dec 3, 2020

What's done:

  • Maven plugin unit tests moved from junit 4 to junit-jupiter-vintage
  • IT for diktat-maven-plugin using maven-itf

This pull request closes #576

### What's done:
* IT for diktat-maven-plugin
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #607 (1a14701) into master (ca50c60) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #607   +/-   ##
=========================================
  Coverage     80.75%   80.75%           
  Complexity     1745     1745           
=========================================
  Files            89       89           
  Lines          4613     4613           
  Branches       1385     1385           
=========================================
  Hits           3725     3725           
  Misses          322      322           
  Partials        566      566           
Flag Coverage Δ Complexity Δ
unittests 80.75% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca50c60...1a14701. Read the comment docs.

@petertrr petertrr marked this pull request as ready for review December 4, 2020 07:38
@petertrr petertrr changed the title Integration tests for diktat plugins Integration tests for diktat-maven-plugin Dec 4, 2020
<artifactId>junit</artifactId>
<version>4.13.1</version>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
Copy link
Member

@orchestr7 orchestr7 Dec 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why vintage engine, not junit5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maven-testing-harness, maven library for unit testing, supports only junit 3 and 4

@MavenGoal("diktat:check@diktat")
fun maven(result: MavenExecutionResult) {
val mavenLog = result.mavenLog.stdout.readText()
println(mavenLog)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug println here?
Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially it was to have access to maven logs, but it can indeed be left for debug only and disabled by default.

Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

### What's done:
* Removed debug output
### What's done:
* Removed debug output
@petertrr petertrr merged commit c73048a into master Dec 7, 2020
@petertrr petertrr deleted the feature/maven-plugin-it#576 branch December 7, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write integration tests for plugins
2 participants