Integration tests for diktat-maven-plugin #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * IT for diktat-maven-plugin
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
=========================================
Coverage 80.75% 80.75%
Complexity 1745 1745
=========================================
Files 89 89
Lines 4613 4613
Branches 1385 1385
=========================================
Hits 3725 3725
Misses 322 322
Partials 566 566
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
### What's done: * maven IT
### What's done: * maven IT
petertrr
changed the title
orchestr7
reviewed
Dec 7, 2020
| <artifactId>junit</artifactId> | ||
| <version>4.13.1</version> | ||
| <groupId>org.junit.vintage</groupId> | ||
| <artifactId>junit-vintage-engine</artifactId> |
There was a problem hiding this comment.
why vintage engine, not junit5?
There was a problem hiding this comment.
maven-testing-harness, maven library for unit testing, supports only junit 3 and 4
orchestr7
reviewed
Dec 7, 2020
| @MavenGoal("diktat:check@diktat") | ||
| fun maven(result: MavenExecutionResult) { | ||
| val mavenLog = result.mavenLog.stdout.readText() | ||
| println(mavenLog) |
There was a problem hiding this comment.
Initially it was to have access to maven logs, but it can indeed be left for debug only and disabled by default.
### What's done: * Removed debug output
### What's done: * Removed debug output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #576