-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix. NPE in indentation rule(#555) #596
Conversation
### What's done: * Fixed bugs
Guess fix for |
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
============================================
- Coverage 81.33% 81.26% -0.07%
- Complexity 1720 1722 +2
============================================
Files 87 87
Lines 4548 4548
Branches 1359 1361 +2
============================================
- Hits 3699 3696 -3
Misses 306 306
- Partials 543 546 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Added this case to CompactInitialization fix tests
# Conflicts: # diktat-rules/src/test/resources/test/smoke/src/main/kotlin/Example4Expected.kt # diktat-rules/src/test/resources/test/smoke/src/main/kotlin/Example4Test.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
### What's done: * Fixed bugs
@@ -9,4 +9,12 @@ httpClient.doRequest() | |||
|
|||
fun setDefaultUrl(httpClient: HttpClient) { | |||
httpClient.url = "http://example.com" | |||
} | |||
|
|||
fun foo() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add check
tests too
This PR fixes NPE in Indentation Rule
This pull request closes #555