Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New changes in the guide from Victor #593

Merged
merged 15 commits into from
Dec 6, 2020
Merged

Conversation

orchestr7
Copy link
Member

Which rule and warnings did you add?

This pull request closes

Actions checklist

  • Implemented Rule, added Warnings
  • Added tests on checks
  • Added tests on fixers
  • Updated diktat-analysis.yml
  • Updated available-rules.md

Fixme

vtchem and others added 7 commits November 13, 2020 15:49
### What's done:
Edited the material and requested review.
…Viktor_Guide_Review

� Conflicts:
�	info/guide/guide-chapter-1.md
�	info/guide/guide-chapter-2.md
�	info/guide/guide-chapter-3.md
�	info/guide/guide-chapter-4.md
�	info/guide/guide-chapter-6.md
### What's done:
Review notes
### What's done:
Edited the material and requested review.
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #593 (408a128) into master (80cad9d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #593   +/-   ##
=========================================
  Coverage     81.21%   81.21%           
  Complexity     1738     1738           
=========================================
  Files            88       88           
  Lines          4574     4574           
  Branches       1371     1371           
=========================================
  Hits           3715     3715           
  Misses          308      308           
  Partials        551      551           
Flag Coverage Δ Complexity Δ
unittests 81.21% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80cad9d...40dfe31. Read the comment docs.

@orchestr7 orchestr7 changed the title Feature/viktor guide review New changes in the guide from Victor Nov 30, 2020
info/guide/guide-chapter-1.md Outdated Show resolved Hide resolved
info/guide/guide-chapter-2.md Outdated Show resolved Hide resolved
info/guide/guide-chapter-2.md Outdated Show resolved Hide resolved
info/guide/guide-chapter-3.md Outdated Show resolved Hide resolved
info/guide/guide-chapter-3.md Outdated Show resolved Hide resolved
orchestr7 and others added 8 commits December 7, 2020 01:02
Co-authored-by: Peter Trifanov <peter.trifanov@mail.ru>
Co-authored-by: Peter Trifanov <peter.trifanov@mail.ru>
Co-authored-by: Peter Trifanov <peter.trifanov@mail.ru>
Co-authored-by: Peter Trifanov <peter.trifanov@mail.ru>
Co-authored-by: Peter Trifanov <peter.trifanov@mail.ru>
### What's done:
Review notes
### What's done:
Review notes
@orchestr7 orchestr7 merged commit 62852a5 into master Dec 6, 2020
@petertrr petertrr added the documentation Improvements or additions to documentation label Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants