Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. Comments should be indented as the code they are commenting #566

Merged
merged 5 commits into from
Nov 30, 2020

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Nov 24, 2020

What's done:

  • Fixed bugs

This pull request closes #553

### What's done:
  * Fixed bugs
@aktsay6 aktsay6 added the bug Something isn't working label Nov 24, 2020
### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #566 (a040137) into master (9224019) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #566   +/-   ##
=========================================
  Coverage     80.81%   80.82%           
  Complexity     1704     1704           
=========================================
  Files            87       87           
  Lines          4358     4365    +7     
  Branches       1342     1345    +3     
=========================================
+ Hits           3522     3528    +6     
  Misses          297      297           
- Partials        539      540    +1     
Flag Coverage Δ Complexity Δ
unittests 80.82% <85.71%> (+<0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../cqfn/diktat/ruleset/utils/indentation/Checkers.kt 77.22% <85.71%> (+0.63%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9224019...a040137. Read the comment docs.

@aktsay6 aktsay6 marked this pull request as ready for review November 24, 2020 11:29
@aktsay6 aktsay6 merged commit 4ce391a into master Nov 30, 2020
@aktsay6 aktsay6 deleted the bugfix/indention-of-comments(#553) branch November 30, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments should be indented as the code they are commenting
2 participants