Bugfix. False-positive LOCAL_VARIABLE_EARLY_DECLARATION #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Fixed bugs
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
============================================
+ Coverage 81.68% 81.73% +0.05%
- Complexity 1641 1665 +24
============================================
Files 79 83 +4
Lines 4139 4211 +72
Branches 1307 1315 +8
============================================
+ Hits 3381 3442 +61
- Misses 229 237 +8
- Partials 529 532 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Fixed bugs
|
Can't reproduce this bug, so added test, that checks it |
petertrr
requested changes
Nov 18, 2020
diktat-rules/src/test/resources/test/funcTest/FunctionalTestFile.kt
Outdated
Show resolved
Hide resolved
| """ | ||
| |class Example { | ||
| | fun some() { | ||
| | val code = ${"\"\"\" class Some {\n \t\t fun for() {} \n \t} \"\"\".trimIndent()"} |
There was a problem hiding this comment.
Why do you need ${} here? Also, this is not exactly example from the issue, there are some different newlines there.
There was a problem hiding this comment.
It is used to insert triple quotes
### What's done: * Fixed bugs
petertrr
requested changes
Nov 23, 2020
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/LocalVariablesWarnTest.kt
Outdated
Show resolved
Hide resolved
### What's done: * Fixed bugs
…-declaration(#488) # Conflicts: # diktat-rules/src/test/resources/test/smoke/src/main/kotlin/Example4Expected.kt # diktat-rules/src/test/resources/test/smoke/src/main/kotlin/Example4Test.kt
petertrr
approved these changes
Nov 23, 2020
aktsay6
deleted the
bugfix/false-positive-local-variable-early-declaration(#488)
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #488