Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rule 6.1.8 regarding getters and setters #518

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Conversation

orchestr7
Copy link
Member

What's done:

  1. Rule that prohibits custom getters/setters for properties

### What's done:
1) Rule that prohibits custom getters/setters for properties
@orchestr7 orchestr7 linked an issue Nov 12, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #518 (160ab75) into master (babf843) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #518      +/-   ##
============================================
+ Coverage     81.78%   81.89%   +0.11%     
- Complexity     1555     1559       +4     
============================================
  Files            73       74       +1     
  Lines          3897     3911      +14     
  Branches       1244     1249       +5     
============================================
+ Hits           3187     3203      +16     
  Misses          211      211              
+ Partials        499      497       -2     
Flag Coverage Δ Complexity Δ
unittests 81.89% <100.00%> (+0.11%) 0.00 <8.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...at-rules/src/main/kotlin/generated/WarningNames.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 98.26% <100.00%> (+0.01%) 10.00 <0.00> (ø)
...qfn/diktat/ruleset/rules/CustomGetterSetterRule.kt 100.00% <100.00%> (ø) 8.00 <8.00> (?)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 97.10% <100.00%> (+0.04%) 8.00 <0.00> (ø)
.../cqfn/diktat/ruleset/rules/WhenMustHaveElseRule.kt 83.33% <0.00%> (+4.95%) 14.00% <0.00%> (-4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update babf843...08f9d87. Read the comment docs.

### What's done:
1) Rule that prohibits custom getters/setters for properties
@orchestr7 orchestr7 merged commit eaa3fca into master Nov 13, 2020
@petertrr petertrr deleted the feature/rule-6.1.8 branch November 18, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommendation 6.1.8: avoid using custom getters and setters
2 participants