NPE in BlockStructureBraces #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: Fixed bug
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
============================================
+ Coverage 81.87% 81.88% +0.01%
- Complexity 1618 1619 +1
============================================
Files 77 77
Lines 4083 4086 +3
Branches 1290 1291 +1
============================================
+ Hits 3343 3346 +3
Misses 218 218
Partials 522 522
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
reviewed
Nov 13, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/BlockStructureBraces.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed after review
orchestr7
reviewed
Nov 16, 2020
| @@ -178,7 +178,7 @@ class BlockStructureBraces(private val configRules: List<RulesConfig>) : Rule("b | |||
| if (braceSpace == null || braceSpace.elementType != WHITE_SPACE) { | |||
| node.addChild(PsiWhiteSpaceImpl(" "), nodeBefore) | |||
| } else { | |||
| (braceSpace as LeafPsiElement).replaceWithText(" ") | |||
| braceSpace.treeParent.replaceWhiteSpaceText(braceSpace, " ") | |||
There was a problem hiding this comment.
here can be problems if treeParent is not a WhiteSpace or does not exist, need to be careful with that
There was a problem hiding this comment.
But above, there is a check for this case checkBraceNode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Fixed bug
closes #481