Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitepaper chapter4 #414

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Whitepaper chapter4 #414

merged 2 commits into from
Oct 19, 2020

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Oct 16, 2020

What's done:

  • Chapter 4

This pull request closes #413

Actions checklist

  • Implemented Rule, added Warnings
  • Added tests on checks
  • Added tests on fixers
  • Updated diktat-analysis.yml
  • Updated available-rules.md

### What's done:
  * Chapter 4
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #414 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #414   +/-   ##
=========================================
  Coverage     82.50%   82.50%           
  Complexity     1346     1346           
=========================================
  Files            65       65           
  Lines          3298     3298           
  Branches       1053     1053           
=========================================
  Hits           2721     2721           
  Misses          178      178           
  Partials        399      399           
Flag Coverage Δ Complexity Δ
#unittests 82.50% <ø> (ø) 1346.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30996d1...11af810. Read the comment docs.

@aktsay6 aktsay6 changed the title feature/wp-chapter4 Whitepaper chapter4 Oct 17, 2020
Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr added this to the diKTat whitepaper milestone Oct 19, 2020
@aktsay6 aktsay6 merged commit 136500f into master Oct 19, 2020
@aktsay6 aktsay6 deleted the feature/wp-chapter4 branch October 19, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chapter 4 of whitepaper
3 participants