-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to kotlin 1.4 #389
Update to kotlin 1.4 #389
Conversation
### What's done: * Updated kotlin * Updated ktlint * Changed kotlin-stdlib dependency to kotlin-stdlib-jdk8 * pom.xml cleanup * Fixed kotlin compiler warnings
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
============================================
- Coverage 83.16% 82.55% -0.61%
- Complexity 1331 1340 +9
============================================
Files 65 65
Lines 3249 3251 +2
Branches 1027 1042 +15
============================================
- Hits 2702 2684 -18
- Misses 176 177 +1
- Partials 371 390 +19
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
### What's done: * Try to rollback to stdlib from stdlib-jdk8
### What's done: This reverts commit 75dae5b
### What's done: * Use old methods for min
### What's done: * Compile with api version 1.3
### What's done: * Use current kotlin api version
### What's done: * Use new methods instead of deprecated
### What's done: * Use apiVersion 1.3
91c1b5b
to
f24fea1
Compare
</goals> | ||
<configuration> | ||
<sourceDirs> | ||
<source>src/main/java</source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no more java?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, there hasn't been any already, so I decided to remove it since it's not needed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What's done:
This pull request closes #250