Update to kotlin 1.4 #389
Merged
Update to kotlin 1.4 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Updated kotlin * Updated ktlint * Changed kotlin-stdlib dependency to kotlin-stdlib-jdk8 * pom.xml cleanup * Fixed kotlin compiler warnings
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
============================================
- Coverage 83.16% 82.55% -0.61%
- Complexity 1331 1340 +9
============================================
Files 65 65
Lines 3249 3251 +2
Branches 1027 1042 +15
============================================
- Hits 2702 2684 -18
- Misses 176 177 +1
- Partials 371 390 +19
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
### What's done: * Try to rollback to stdlib from stdlib-jdk8
### What's done: This reverts commit 75dae5b
### What's done: * Use old methods for min
### What's done: * Compile with api version 1.3
### What's done: * Use current kotlin api version
### What's done: * Use new methods instead of deprecated
### What's done: * Use apiVersion 1.3
petertrr
force-pushed
the
feature/kotlin-1.4
branch
from
91c1b5b
to
f24fea1
Compare
orchestr7
reviewed
Oct 14, 2020
| </goals> | ||
| <configuration> | ||
| <sourceDirs> | ||
| <source>src/main/java</source> |
There was a problem hiding this comment.
well, there hasn't been any already, so I decided to remove it since it's not needed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #250