-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule 5.2.1 lambda parameters order #360
Conversation
### What's done: Implemented new rule
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
============================================
+ Coverage 82.73% 82.80% +0.06%
- Complexity 1214 1219 +5
============================================
Files 59 60 +1
Lines 2989 3001 +12
Branches 952 954 +2
============================================
+ Hits 2473 2485 +12
Misses 171 171
Partials 345 345
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions, see comments
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/LambdaParameterOrder.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/LambdaParameterOrder.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed some bugs after review
### What's done: Add suppress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/LambdaParameterOrder.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed before merge
What's done:
Implemented new rule
Actions checklist