Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule 5.2.1 lambda parameters order #360

Merged
merged 7 commits into from
Oct 6, 2020
Merged

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Oct 5, 2020

What's done:

Implemented new rule

Actions checklist

### What's done:
   Implemented new rule
@kentr0w kentr0w added the enhancement New feature or request label Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #360 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #360      +/-   ##
============================================
+ Coverage     82.73%   82.80%   +0.06%     
- Complexity     1214     1219       +5     
============================================
  Files            59       60       +1     
  Lines          2989     3001      +12     
  Branches        952      954       +2     
============================================
+ Hits           2473     2485      +12     
  Misses          171      171              
  Partials        345      345              
Flag Coverage Δ Complexity Δ
#unittests 82.80% <100.00%> (+0.06%) 1219.00 <5.00> (+5.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...at-rules/src/main/kotlin/generated/WarningNames.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 97.00% <100.00%> (+0.03%) 9.00 <0.00> (ø)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 98.00% <100.00%> (+0.04%) 3.00 <0.00> (ø)
.../cqfn/diktat/ruleset/rules/LambdaParameterOrder.kt 100.00% <100.00%> (ø) 5.00 <5.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b08f2...622cc1f. Read the comment docs.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions, see comments

### What's done:
    Fixed some bugs after review
### What's done:
    Add suppress
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentr0w kentr0w merged commit db3e907 into master Oct 6, 2020
@kentr0w kentr0w deleted the feature/lambda-parameter-order branch October 6, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule 5.2.1 The lambda parameter of the function should be placed in the last place in the argument list
2 participants