Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#315 Configurable indentation size. #316

Merged
merged 4 commits into from
Sep 22, 2020
Merged

#315 Configurable indentation size. #316

merged 4 commits into from
Sep 22, 2020

Conversation

portlek
Copy link
Contributor

@portlek portlek commented Sep 22, 2020

This pull request closes #315

@portlek portlek changed the title Merge branch 'master' into 'feature/configurableindentation', #315 Configurable indentation size. Sep 22, 2020
orchestr7
orchestr7 reviewed Sep 22, 2020
View reviewed changes
Copy link
Member

@orchestr7 orchestr7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, Thank you very much!
But could you please also update files with configurations like

diktat-analysis.yml? (in parent and in resources)
diktat-analysis-huawei.yml

That will make this configuration visible for users

orchestr7
orchestr7 approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@orchestr7 orchestr7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, don't forget to add a star to the project if you want to make it popular :)

@portlek
Copy link
Contributor Author

portlek commented Sep 22, 2020

I guess It's done @akuleshov7 isn't it?

@orchestr7 orchestr7 merged commit 231a865 into saveourtool:master Sep 22, 2020
@orchestr7
Copy link
Member

I guess It's done @akuleshov7 isn't it?

yes, thank you!

@portlek portlek deleted the feature/configurableindentation branch September 22, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orchestr7 orchestr7 orchestr7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configurable Indentation
2 participants
@portlek @orchestr7