Rule 4.1.1 float arithmetic #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Initial implementation * Tests
…float-ariphmethic
### What's done: * Update yml files and available-rules.md
### What's done: * Added new rule to DiktatRuleSetProvider * Added maven central badge
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
============================================
- Coverage 82.38% 82.29% -0.10%
- Complexity 1000 1016 +16
============================================
Files 51 52 +1
Lines 2578 2627 +49
Branches 809 830 +21
============================================
+ Hits 2124 2162 +38
Misses 169 169
- Partials 285 296 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
orchestr7
reviewed
Sep 21, 2020
...rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/calculations/AccurateCalculationsRule.kt
Show resolved
Hide resolved
orchestr7
reviewed
Sep 21, 2020
orchestr7
reviewed
Sep 21, 2020
...rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/calculations/AccurateCalculationsRule.kt
Outdated
Show resolved
Hide resolved
### What's done: * Fixes
…float-ariphmethic # Conflicts: # diktat-analysis.yml # diktat-rules/src/main/kotlin/generated/WarningNames.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/resources/diktat-analysis-huawei.yml # diktat-rules/src/main/resources/diktat-analysis.yml # info/available-rules.md
### What's done: * Fixes
kentr0w
reviewed
Sep 24, 2020
Fair enough, I forgot about it. |
### What's done: * Added PERC and PERCEQ to handled operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which rule and warnings did you add?
This pull request closes #289
Actions checklist
* [ ] Added tests on fixersFixme