-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommendation 4.2.2 type alias #288
Conversation
### What's done: Added new rule
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
=========================================
Coverage 81.30% 81.31%
- Complexity 960 967 +7
=========================================
Files 50 51 +1
Lines 2519 2531 +12
Branches 789 793 +4
=========================================
+ Hits 2048 2058 +10
Misses 187 187
- Partials 284 286 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: Added soe tests Changed warn's message
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/TypeAliasRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/TypeAliasRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/TypeAliasRule.kt
Outdated
Show resolved
Hide resolved
### What's done: Added handler for generic count Added tests
### What's done: Added tags for tests
…ion-4.2.2-type-alias
### What's done: Fixed after merged
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/TypeAliasRule.kt
Show resolved
Hide resolved
### What's done: Added comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but take a look at comments
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/TypeAliasRule.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/TypeAliasRule.kt
Outdated
Show resolved
Hide resolved
### What's done: Added KDoc Added to another ymls file
What's done:
Recommendation 4.2.2 type alias
Closes #293
Actions checklist