Recommendation 4.2.2 type alias #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done:
Added new rule
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
=========================================
Coverage 81.30% 81.31%
- Complexity 960 967 +7
=========================================
Files 50 51 +1
Lines 2519 2531 +12
Branches 789 793 +4
=========================================
+ Hits 2048 2058 +10
Misses 187 187
- Partials 284 286 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done:
Added soe tests
Changed warn's message
petertrr
requested changes
Sep 15, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/TypeAliasRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/TypeAliasRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/TypeAliasRule.kt
Outdated
Show resolved
Hide resolved
### What's done:
Added handler for generic count
Added tests
### What's done:
Added tags for tests
…ion-4.2.2-type-alias
### What's done:
Fixed after merged
petertrr
reviewed
Sep 16, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/TypeAliasRule.kt
Show resolved
Hide resolved
### What's done:
Added comments
petertrr
approved these changes
Sep 17, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/TypeAliasRule.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/TypeAliasRule.kt
Outdated
Show resolved
Hide resolved
### What's done: Added KDoc Added to another ymls file
petertrr
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Recommendation 4.2.2 type alias
Closes #293
Actions checklist