Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on symbols in test classes #271

Merged
merged 6 commits into from
Sep 15, 2020

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Sep 11, 2020

What's done:

Added handle for Test annotation
closes #217

### What's done:
    Added handle for Test annotation
@kentr0w kentr0w added the bug Something isn't working label Sep 11, 2020
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #271 into master will decrease coverage by 0.18%.
The diff coverage is 61.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #271      +/-   ##
============================================
- Coverage     81.41%   81.23%   -0.19%     
  Complexity      956      956              
============================================
  Files            50       50              
  Lines          2508     2510       +2     
  Branches        780      782       +2     
============================================
- Hits           2042     2039       -3     
- Misses          184      190       +6     
+ Partials        282      281       -1     
Flag Coverage Δ Complexity Δ
#unittests 81.23% <61.53%> (-0.19%) 956.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...fn/diktat/common/config/rules/RulesConfigReader.kt 42.85% <0.00%> (-11.69%) 4.00 <0.00> (ø)
...g/cqfn/diktat/ruleset/utils/FunctonASTNodeUtils.kt 70.37% <ø> (-2.13%) 0.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 83.52% <72.72%> (-0.72%) 0.00 <0.00> (ø)
...org/cqfn/diktat/ruleset/rules/kdoc/KdocComments.kt 91.66% <83.33%> (-3.58%) 15.00 <0.00> (+1.00) ⬇️
...lin/org/cqfn/diktat/ruleset/rules/PackageNaming.kt 92.68% <100.00%> (+1.01%) 30.00 <0.00> (ø)
.../org/cqfn/diktat/ruleset/rules/kdoc/KdocMethods.kt 89.24% <100.00%> (+0.70%) 69.00 <0.00> (-1.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5076f3d...b29646b. Read the comment docs.

### What's done:
    Simplified code
### What's done:
    Simplified code
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix issues found by analysis in diktat check (mostly documentation to your newly added class)

### What's done:
    Added `open` modifiers to class
    Added KDoc
### What's done:
    Added KDoc
…n-in-test

# Conflicts:
#	diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentr0w kentr0w merged commit b2d6ac6 into master Sep 15, 2020
@kentr0w kentr0w deleted the bugfix/documentation-in-test branch September 15, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation on symbols in test classes
2 participants