loggers sometimes shouldn't be first #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Added simple dependency check when looking for logger that could be first property * Added test (#1602)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/ClassLikeStructuresOrderRule.kt
Fixed
Show fixed
Hide fixed
...rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/ClassLikeStructuresOrderRule.kt
Fixed
Show fixed
Hide fixed
### What's done: * Added simple dependency check when looking for logger that could be first property * Added test (#1602)
...st-framework/src/main/kotlin/org/cqfn/diktat/test/framework/processing/TestComparatorUnit.kt
Fixed
Show fixed
Hide fixed
### What's done: * Added simple dependency check when looking for logger that could be first property * Added test (#1602)
Codecov Report
@@ Coverage Diff @@
## master #1624 +/- ##
============================================
+ Coverage 82.47% 82.49% +0.01%
Complexity 2334 2334
============================================
Files 112 112
Lines 7862 7876 +14
Branches 2045 2047 +2
============================================
+ Hits 6484 6497 +13
Misses 452 452
- Partials 926 927 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sanyavertolet
changed the title
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 166 files ±0 166 suites ±0 25m 54s ⏱️ - 1m 51s For more details on these failures, see this check. Results for commit b9f84a5. ± Comparison against base commit cb102a2. |
nulls
approved these changes
Mar 16, 2023
sanyavertolet
deleted the
bugfix/WRONG_ORDER_IN_CLASS_LIKE_STRUCTURES_loggers
branch
0x6675636b796f75676974687562
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.