Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the new rule set API #1570

Conversation

0x6675636b796f75676974687562
Copy link
Member

@0x6675636b796f75676974687562 0x6675636b796f75676974687562 commented Nov 16, 2022

What's done:

@0x6675636b796f75676974687562 0x6675636b796f75676974687562 added this to the ktlint-wrapper milestone Nov 16, 2022
@nulls
Copy link
Member

nulls commented Nov 16, 2022

maybe migrate to the old rule set API?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

1 997 tests   1 982 ✔️  2m 48s ⏱️
   162 suites       15 💤
   162 files           0

Results for commit c246dfd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

1 978 tests   1 963 ✔️  1m 59s ⏱️
   161 suites       15 💤
   161 files           0

Results for commit c246dfd.

♻️ This comment has been updated with latest results.

@0x6675636b796f75676974687562 0x6675636b796f75676974687562 marked this pull request as ready for review November 18, 2022 10:56
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feature/ktlint-wrapper@b8f4350). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c246dfd differs from pull request most recent head 113fbe5. Consider uploading reports for the commit 113fbe5 to get more accurate results

@@                    Coverage Diff                    @@
##             feature/ktlint-wrapper    #1570   +/-   ##
=========================================================
  Coverage                          ?   81.57%           
  Complexity                        ?     2318           
=========================================================
  Files                             ?      118           
  Lines                             ?     7946           
  Branches                          ?     2039           
=========================================================
  Hits                              ?     6482           
  Misses                            ?      544           
  Partials                          ?      920           
Flag Coverage Δ
unittests 81.57% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

### What's done:

 - Deprecated API usages removed (except for `DiktatBaseMojo`).
 - @Suppress("Deprecation") annotations removed (except for `DiktatBaseMojo`).
 - A part of #1543.
@nulls nulls mentioned this pull request Apr 6, 2023
4 tasks
@nulls nulls modified the milestones: ktlint-wrapper, 2.0.0 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KtLint: migrate from RuleSetProvider to RuleSetProviderV2
3 participants