-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder to run Diktat #1562
Builder to run Diktat #1562
Conversation
### What's done: - added a builder to run Diktat - reused it in maven plugin It's part of #1561
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good as an encapsulation and abstraction of diktat/ktlint interaction, which will be good for our maven plugin and also for spotless. We'll still (probably) need to maintain current state of CLI (however, we do have diktat-cli
already) and integrating this change into gradle plugin will be a huge change too.
We can make |
diktat-ruleset/src/main/kotlin/org/cqfn/diktat/ktlint/LintErrorWrapper.kt
Outdated
Show resolved
Hide resolved
diktat-ruleset/src/main/kotlin/org/cqfn/diktat/DiktatProcessCommand.kt
Outdated
Show resolved
Hide resolved
diktat-ruleset/src/main/kotlin/org/cqfn/diktat/DiktatProcessCommand.kt
Outdated
Show resolved
Hide resolved
diktat-ruleset/src/main/kotlin/org/cqfn/diktat/DiktatProcessCommand.kt
Outdated
Show resolved
Hide resolved
diktat-maven-plugin/src/main/kotlin/org/cqfn/diktat/plugin/maven/DiktatMojo.kt
Outdated
Show resolved
Hide resolved
diktat-ruleset/src/main/kotlin/org/cqfn/diktat/api/DiktatCallback.kt
Outdated
Show resolved
Hide resolved
diktat-ruleset/src/main/kotlin/org/cqfn/diktat/DiktatProcessCommand.kt
Outdated
Show resolved
Hide resolved
diktat-ruleset/src/main/kotlin/org/cqfn/diktat/api/DiktatCallback.kt
Outdated
Show resolved
Hide resolved
diktat-maven-plugin/src/main/kotlin/org/cqfn/diktat/plugin/maven/DiktatBaseMojo.kt
Show resolved
Hide resolved
diktat-ruleset/src/main/kotlin/org/cqfn/diktat/DiktatProcessCommand.kt
Outdated
Show resolved
Hide resolved
diktat-ruleset/src/main/kotlin/org/cqfn/diktat/DiktatProcessCommand.kt
Outdated
Show resolved
Hide resolved
diktat-ruleset/src/main/kotlin/org/cqfn/diktat/DiktatProcessCommand.kt
Outdated
Show resolved
Hide resolved
diktat-ruleset/src/main/kotlin/org/cqfn/diktat/DiktatProcessCommand.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## feature/ktlint-wrapper #1562 +/- ##
=========================================================
Coverage ? 81.50%
Complexity ? 2315
=========================================================
Files ? 116
Lines ? 7925
Branches ? 2040
=========================================================
Hits ? 6459
Misses ? 545
Partials ? 921
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
What's done:
It closes #1563