Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder to run Diktat #1562

Merged
merged 11 commits into from
Nov 16, 2022
Merged

Builder to run Diktat #1562

merged 11 commits into from
Nov 16, 2022

Conversation

nulls
Copy link
Member

@nulls nulls commented Nov 15, 2022 •
edited
Loading

What's done:

  • added a builder to run Diktat
  • reused it in maven plugin

It closes #1563

@nulls
Builder to run Diktat
98fb63d 
### What's done:
- added a builder to run Diktat
- reused it in maven plugin

It's part of #1561
@nulls nulls self-assigned this Nov 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2022 •
edited
Loading

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

1 997 tests   1 982 ✔️  3m 7s ⏱️
   162 suites       15 💤
   162 files           0 ❌

Results for commit c78cda1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2022 •
edited
Loading

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

1 978 tests   1 963 ✔️  1m 46s ⏱️
   161 suites       15 💤
   161 files           0 ❌

Results for commit c78cda1.

♻️ This comment has been updated with latest results.

petertrr
petertrr reviewed Nov 15, 2022
View reviewed changes
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as an encapsulation and abstraction of diktat/ktlint interaction, which will be good for our maven plugin and also for spotless. We'll still (probably) need to maintain current state of CLI (however, we do have diktat-cli already) and integrating this change into gradle plugin will be a huge change too.

@nulls
Copy link
Member Author

nulls commented Nov 15, 2022

integrating this change into gradle plugin will be a huge change too.

We can make diktat.jar as executable and run it without ktlint. It should resolve cli and gradle issues

@nulls nulls changed the base branch from master to feature/ktlint-wrapper November 15, 2022 13:40
@nulls nulls closed this Nov 15, 2022
@nulls nulls reopened this Nov 15, 2022
@nulls nulls modified the milestones: 1.2.4.2, 1.2.5 Nov 15, 2022
@nulls nulls modified the milestones: 1.2.5, ktlint-wrapper Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (feature/ktlint-wrapper@cf19276). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             feature/ktlint-wrapper    #1562   +/-   ##
=========================================================
  Coverage                          ?   81.50%           
  Complexity                        ?     2315           
=========================================================
  Files                             ?      116           
  Lines                             ?     7925           
  Branches                          ?     2040           
=========================================================
  Hits                              ?     6459           
  Misses                            ?      545           
  Partials                          ?      921
Flag Coverage Δ
unittests 81.50% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nulls nulls merged commit b8f4350 into feature/ktlint-wrapper Nov 16, 2022
@nulls nulls deleted the feature/ktlint-wrapper#1561 branch November 16, 2022 10:57
@nulls nulls modified the milestones: ktlint-wrapper, 2.0.0 Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertrr petertrr petertrr left review comments

@0x6675636b796f75676974687562 0x6675636b796f75676974687562 0x6675636b796f75676974687562 approved these changes

@orchestr7 orchestr7 Awaiting requested review from orchestr7

Assignees

@nulls nulls

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Create a wrapper to run diktat in maven plugin
3 participants
@nulls @petertrr @0x6675636b796f75676974687562