Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-delete all set of in descriptions of rule classes #1273

Merged
merged 3 commits into from
Apr 29, 2022

Conversation

Arrgentum
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #1273 (aaccd53) into master (d575c3f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1273      +/-   ##
============================================
- Coverage     82.37%   82.36%   -0.02%     
  Complexity     2550     2550              
============================================
  Files           105      105              
  Lines          7207     7202       -5     
  Branches       2020     2020              
============================================
- Hits           5937     5932       -5     
  Misses          351      351              
  Partials        919      919              
Flag Coverage Δ
unittests 82.36% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ktat/ruleset/rules/chapter2/kdoc/KdocFormatting.kt 84.11% <ø> (ø)
...tat/ruleset/rules/chapter3/BlockStructureBraces.kt 85.50% <ø> (ø)
...at/ruleset/rules/chapter3/ConsecutiveSpacesRule.kt 93.54% <ø> (ø)
...fn/diktat/ruleset/rules/chapter3/EnumsSeparated.kt 97.87% <ø> (ø)
...org/cqfn/diktat/ruleset/rules/chapter3/SortRule.kt 88.65% <ø> (ø)
...tat/ruleset/rules/chapter3/files/BlankLinesRule.kt 96.66% <ø> (ø)
.../ruleset/rules/chapter3/files/FileStructureRule.kt 83.15% <ø> (ø)
.../ruleset/rules/chapter3/files/TopLevelOrderRule.kt 96.07% <ø> (ø)
...diktat/ruleset/rules/chapter2/kdoc/KdocComments.kt 87.70% <100.00%> (-0.07%) ⬇️
.../diktat/ruleset/rules/chapter2/kdoc/KdocMethods.kt 86.16% <100.00%> (-0.09%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d575c3f...aaccd53. Read the comment docs.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add a more descriptive commit message when squashing

@Arrgentum Arrgentum changed the title delete all set of in descriptions of rule classes -delete all set of in descriptions of rule classes Apr 21, 2022
@Arrgentum Arrgentum changed the title -delete all set of in descriptions of rule classes #Whats Done:-delete all set of in descriptions of rule classes Apr 21, 2022
@Arrgentum Arrgentum changed the title #Whats Done:-delete all set of in descriptions of rule classes #Whats Done: -delete all set of in descriptions of rule classes Apr 21, 2022
@Arrgentum Arrgentum changed the title #Whats Done: -delete all set of in descriptions of rule classes -delete all set of in descriptions of rule classes Apr 21, 2022
@petertrr petertrr enabled auto-merge (squash) April 29, 2022 08:08
@petertrr petertrr merged commit 7b4b379 into master Apr 29, 2022
@petertrr petertrr deleted the bugfix/delete_setOf branch April 29, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants