Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven-plugin: Fix scopes of maven dependencies #1257

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Apr 5, 2022

What's done:

  • Some dependencies for maven plugins are included in maven runtime and thus should have provided scope

This pull request closes #1249

### What's done:
* Some dependencies for maven plugins are included in maven runtime and thus should have `provided` scope
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #1257 (b8ea127) into master (e25792b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1257   +/-   ##
=========================================
  Coverage     83.88%   83.88%           
  Complexity     2551     2551           
=========================================
  Files           105      105           
  Lines          7198     7198           
  Branches       1951     1951           
=========================================
  Hits           6038     6038           
  Misses          352      352           
  Partials        808      808           
Flag Coverage Δ
unittests 83.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e25792b...b8ea127. Read the comment docs.

@petertrr petertrr enabled auto-merge (squash) April 6, 2022 12:00
@petertrr petertrr merged commit 41c161a into master Apr 6, 2022
@petertrr petertrr deleted the bugfix/maven-deps-scope#1249 branch April 6, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maven plugin: Some dependencies of Maven Plugins are expected to be in provided scope.
2 participants