Improve autofix in AVOID_NULL_CHECKS rule #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * added tests (#899)
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * added tests (#899)
…_null_checks_rule' into feature/improve_autofix_in_avoid_null_checks_rule
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * added tests (#899)
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * added tests (#899)
…_null_checks_rule' into feature/improve_autofix_in_avoid_null_checks_rule
Codecov Report
@@ Coverage Diff @@
## master #1201 +/- ##
============================================
+ Coverage 83.81% 83.83% +0.01%
- Complexity 2528 2536 +8
============================================
Files 103 103
Lines 7141 7137 -4
Branches 1938 1937 -1
============================================
- Hits 5985 5983 -2
Misses 352 352
+ Partials 804 802 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
reviewed
Feb 1, 2022
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
orchestr7
requested changes
Feb 2, 2022
|
could you please also update |
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * added tests (#1149)
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * improved autofix: now we count statements, not lines * added tests (#1201)
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * improved autofix: now we count statements, not lines * added tests (#1201)
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * improved autofix: now we count statements, not lines * added tests (#1201)
petertrr
approved these changes
Feb 28, 2022
orchestr7
approved these changes
Mar 9, 2022
sanyavertolet
deleted the
feature/improve_autofix_in_avoid_null_checks_rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #899
Actions checklist
letandrunin some cases