-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve autofix in AVOID_NULL_CHECKS rule #1201
Improve autofix in AVOID_NULL_CHECKS rule #1201
Conversation
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * added tests (#899)
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * added tests (#899)
…_null_checks_rule' into feature/improve_autofix_in_avoid_null_checks_rule
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * added tests (#899)
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * added tests (#899)
…_null_checks_rule' into feature/improve_autofix_in_avoid_null_checks_rule
Codecov Report
@@ Coverage Diff @@
## master #1201 +/- ##
============================================
+ Coverage 83.81% 83.83% +0.01%
- Complexity 2528 2536 +8
============================================
Files 103 103
Lines 7141 7137 -4
Branches 1938 1937 -1
============================================
- Hits 5985 5983 -2
Misses 352 352
+ Partials 804 802 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't merge it until the previous releases will be made
could you please also update |
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * added tests (#1149)
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * improved autofix: now we count statements, not lines * added tests (#1201)
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * improved autofix: now we count statements, not lines * added tests (#1201)
### What's done: * improved autofix: now we don't use `let` and `run` in some cases * improved autofix: now we count statements, not lines * added tests (#1201)
This pull request closes #899
Actions checklist
let
andrun
in some cases