Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support baseline mode #1194

Merged
merged 8 commits into from
Jan 31, 2022
Merged

Support baseline mode #1194

merged 8 commits into from
Jan 31, 2022

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Jan 28, 2022

What's done:

  • Support in gradle plugin (works almost out of the box with correct CLI flag)
  • Support in maven plugin (added some new code, as maven-plugin doesn't delegate to ktlint CLI)
  • Describe in README.md

This pull request closes #1129

### What's done:
* Support in gradle plugin
* Describe in README.md
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #1194 (e07a90f) into master (749587a) will decrease coverage by 0.12%.
The diff coverage is 44.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1194      +/-   ##
============================================
- Coverage     84.20%   84.07%   -0.13%     
  Complexity     2514     2514              
============================================
  Files           103      103              
  Lines          7070     7089      +19     
  Branches       1911     1919       +8     
============================================
+ Hits           5953     5960       +7     
- Misses          333      339       +6     
- Partials        784      790       +6     
Flag Coverage Δ
unittests 84.07% <44.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 87.35% <0.00%> (-2.06%) ⬇️
...lin/org/cqfn/diktat/plugin/maven/DiktatBaseMojo.kt 55.68% <45.45%> (-4.05%) ⬇️
...n/org/cqfn/diktat/plugin/gradle/DiktatExtension.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 749587a...e07a90f. Read the comment docs.

reporterImpl.onLintError(file.path, lintError, isCorrected)
lintErrors.add(lintError)
if (baselineErrors.none {
// ktlint's BaselineReporter stores only these fields
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petertrr petertrr marked this pull request as ready for review January 31, 2022 12:13
@orchestr7
Copy link
Member

Could you please also update the link on our telegram group: https://t.me/diktat_help

@petertrr
Copy link
Member Author

petertrr commented Jan 31, 2022

Could you please also update the link on our telegram group: https://t.me/diktat_help

Yes, sure, fixed some other problems in our readme too

@petertrr petertrr enabled auto-merge (squash) January 31, 2022 13:47
@petertrr petertrr merged commit 78a339f into master Jan 31, 2022
@petertrr petertrr deleted the feature/baseline#1129 branch January 31, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check new ktlint's baseline mode with diktat, add docs
3 participants