KotlinParseException on string concatenation for if expression #1190
Conversation
Cheshiriks
force-pushed
the
bugfix/if-expression
branch
from
889be47
to
118de7a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1190 +/- ##
============================================
- Coverage 84.52% 84.49% -0.04%
+ Complexity 2515 2511 -4
============================================
Files 103 103
Lines 7055 7054 -1
Branches 1902 1902
============================================
- Hits 5963 5960 -3
Misses 306 306
- Partials 786 788 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| val myTest25 = "String ${valueStr?.value}" |
There was a problem hiding this comment.
two issues contained 2 tests. Or they are the same?
There was a problem hiding this comment.
This is one problem caused by the lack of an IfExpression check.
| @@ -155,7 +156,8 @@ class StringConcatenationRule(configRules: List<RulesConfig>) : DiktatRule( | |||
| val rvalueTextNew = rvalueText?.trim('"') | |||
| return "$lvalueText$rvalueTextNew" | |||
| } else if (binaryExpressionPsi.isRvalueCallExpression() || binaryExpressionPsi.isRvalueDotQualifiedExpression() || | |||
| binaryExpressionPsi.isRvalueOperation() || binaryExpressionPsi.isRvalueSafeQualifiedExpression()) { | |||
There was a problem hiding this comment.
Do we need this branch at all? Or can it be the default behaviour (like the last branch of if) when right side is a general KtExpression? I don't like that we need to add so many types here, I bet it will fire once again on something else.
There was a problem hiding this comment.
What is the reason to leave separate branch for call expression?
There was a problem hiding this comment.
ReferenceExpression is always a child for the CallExpression. That's why the CallExpression requires a separate condition.
example
- -foo() [CallExpression]
- -- foo [ReferenceExpression]
There was a problem hiding this comment.
But then isRvalueReferenceExpression() will be false and we'll get in .isRvalueExpression() condition, won't we?
There was a problem hiding this comment.
No isRvalueReferenceExpression return true if parent or first child will be True
Cheshiriks
force-pushed
the
bugfix/if-expression
branch
2 times, most recently
from
3aad270
to
a4e4d51
Compare
Cheshiriks
force-pushed
the
bugfix/if-expression
branch
from
a4e4d51
to
7d89624
Compare
What's done:
closes
KotlinParseExceptionin [STRING_CONCATENATION] #1076closes One more
org.cqfn.diktat.ruleset.utils.KotlinParseException: Text is not valid#1141