Improvements for Copyrights rule - support pattern for the current year in the configuration #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * .
Codecov Report
@@ Coverage Diff @@
## master #1154 +/- ##
=========================================
Coverage 84.72% 84.72%
Complexity 2482 2482
=========================================
Files 102 102
Lines 6973 6974 +1
Branches 1872 1872
=========================================
+ Hits 5908 5909 +1
Misses 302 302
Partials 763 763
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
orchestr7
reviewed
Dec 20, 2021
| // need to make sure that copyright year is consistent with current year | ||
| val copyrightText = configuration.getCopyrightText() | ||
|
|
||
| if (makeCopyrightCorrectYear(copyrightText).isNotEmpty()) { |
There was a problem hiding this comment.
Please add this to the readme of the rule
orchestr7
approved these changes
Dec 20, 2021
|
@kgevorkyan please test (with a binary file manually) on several big files (where you will add the copyright) after the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: