-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for Copyrights rule - support pattern for the current year in the configuration #1154
Conversation
### What's done: * .
Codecov Report
@@ Coverage Diff @@
## master #1154 +/- ##
=========================================
Coverage 84.72% 84.72%
Complexity 2482 2482
=========================================
Files 102 102
Lines 6973 6974 +1
Branches 1872 1872
=========================================
+ Hits 5908 5909 +1
Misses 302 302
Partials 763 763
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
// need to make sure that copyright year is consistent with current year | ||
val copyrightText = configuration.getCopyrightText() | ||
|
||
if (makeCopyrightCorrectYear(copyrightText).isNotEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this to the readme of the rule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@kgevorkyan please test (with a binary file manually) on several big files (where you will add the copyright) after the merge. |
What's done: