Fix: Don't check length of import statements #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Fix bug in code * Update test
### What's done: * Override repositories for gradle plugins because of unstable bintray
Codecov Report
@@ Coverage Diff @@
## master #1108 +/- ##
============================================
+ Coverage 83.41% 83.43% +0.01%
- Complexity 2460 2462 +2
============================================
Files 102 102
Lines 6145 6146 +1
Branches 1841 1840 -1
============================================
+ Hits 5126 5128 +2
Misses 274 274
+ Partials 745 744 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
commented
Nov 9, 2021
kgevorkyan
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Which rule and warnings did you add?
This pull request closes #1077
We actually had logic, which doesn't check length of package directives and import statements. However, due to a small bug, it was not working from the very beginning...