Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in GENERIC_VARIABLE_WRONG_DECLARATION #1098

Merged
merged 4 commits into from
Nov 8, 2021

Conversation

kgevorkyan
Copy link
Member

@kgevorkyan kgevorkyan commented Nov 8, 2021

What's done:

  • Fix bug - allow cases with wild card types
  • Add tests

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #1098 (83dc50c) into master (45f91c9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1098   +/-   ##
=========================================
  Coverage     83.40%   83.40%           
- Complexity     2453     2458    +5     
=========================================
  Files           102      102           
  Lines          6139     6141    +2     
  Branches       1839     1840    +1     
=========================================
+ Hits           5120     5122    +2     
  Misses          274      274           
  Partials        745      745           
Flag Coverage Δ
unittests 83.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...les/chapter4/VariableGenericTypeDeclarationRule.kt 80.64% <100.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f91c9...83dc50c. Read the comment docs.

@kgevorkyan kgevorkyan marked this pull request as ready for review November 8, 2021 12:32
@kgevorkyan kgevorkyan enabled auto-merge (squash) November 8, 2021 12:38
@kgevorkyan kgevorkyan linked an issue Nov 8, 2021 that may be closed by this pull request
@kgevorkyan kgevorkyan merged commit d249fbb into master Nov 8, 2021
@petertrr petertrr deleted the bugfix/npe_in_generic_declaration branch November 8, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null pointer exception at: GENERIC_VARIABLE_WRONG_DECLARATION
2 participants