Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE in COMPLEX_BOOLEAN_EXPRESSION rule #1052

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

kgevorkyan
Copy link
Member

@kgevorkyan kgevorkyan commented Sep 13, 2021

What's done

  • Modify warning message in aim to avoid confusions
  • Fix NPE for conditions, which simplified to single statements in fix mode - they have no additional parenthesis

### What's done:
* WIP
@kgevorkyan kgevorkyan linked an issue Sep 13, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #1052 (e0199e6) into master (56168af) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1052      +/-   ##
============================================
- Coverage     83.41%   83.40%   -0.02%     
- Complexity     2446     2447       +1     
============================================
  Files           102      102              
  Lines          6120     6122       +2     
  Branches       1832     1833       +1     
============================================
+ Hits           5105     5106       +1     
  Misses          273      273              
- Partials        742      743       +1     
Flag Coverage Δ
unittests 83.40% <80.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/ruleset/rules/chapter3/BooleanExpressionsRule.kt 92.45% <75.00%> (-0.82%) ⬇️
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 98.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56168af...e0199e6. Read the comment docs.

@kgevorkyan kgevorkyan force-pushed the bugfix/npe_in_boolean_expression_rule branch from 1ccf274 to 3c41a05 Compare September 14, 2021 12:51
### What's done:
* Update warning message
@kgevorkyan kgevorkyan force-pushed the bugfix/npe_in_boolean_expression_rule branch from 3c41a05 to e0199e6 Compare September 14, 2021 12:52
@kgevorkyan kgevorkyan marked this pull request as ready for review September 14, 2021 13:06
@kgevorkyan kgevorkyan merged commit 6a0d4ec into master Sep 14, 2021
@kgevorkyan kgevorkyan deleted the bugfix/npe_in_boolean_expression_rule branch September 14, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect warning message for COMPLEX_BOOLEAN_EXPRESSION rule
2 participants