-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expect/actual removing abstract modifier #1011
Conversation
53fcd7c
to
82dab7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
============================================
+ Coverage 83.76% 83.81% +0.04%
Complexity 2427 2427
============================================
Files 102 102
Lines 6111 6103 -8
Branches 1810 1806 -4
============================================
- Hits 5119 5115 -4
+ Misses 269 268 -1
+ Partials 723 720 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * fixed bug in CLASS_SHOULD_NOT_BE_ABSTRACT * now replace abstract modifier on open modifier Closes #1001
82dab7f
to
8c42335
Compare
...-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter6/classes/AbstractClassesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter6/AbstractClassesWarnTest.kt
Outdated
Show resolved
Hide resolved
### What's done: * fixed bug in CLASS_SHOULD_NOT_BE_ABSTRACT * now replace abstract modifier on open modifier Closes #1001
...-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter6/classes/AbstractClassesRule.kt
Outdated
Show resolved
Hide resolved
### What's done: * fixed bug in CLASS_SHOULD_NOT_BE_ABSTRACT * now replace abstract modifier on open modifier Closes #1001
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update docs on this rule
### What's done: * fixed bug in CLASS_SHOULD_NOT_BE_ABSTRACT * now replace abstract modifier on open modifier Closes #1001
What's done:
Closes expect/actual removing abstract modifier #1001