expect/actual removing abstract modifier #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheshiriks
force-pushed
the
bugfix/abstract-modifier-rule
branch
from
53fcd7c
to
82dab7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
============================================
+ Coverage 83.76% 83.81% +0.04%
Complexity 2427 2427
============================================
Files 102 102
Lines 6111 6103 -8
Branches 1810 1806 -4
============================================
- Hits 5119 5115 -4
+ Misses 269 268 -1
+ Partials 723 720 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * fixed bug in CLASS_SHOULD_NOT_BE_ABSTRACT * now replace abstract modifier on open modifier Closes #1001
Cheshiriks
force-pushed
the
bugfix/abstract-modifier-rule
branch
from
82dab7f
to
8c42335
Compare
petertrr
requested changes
Jul 30, 2021
...-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter6/classes/AbstractClassesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter6/AbstractClassesWarnTest.kt
Outdated
Show resolved
Hide resolved
### What's done: * fixed bug in CLASS_SHOULD_NOT_BE_ABSTRACT * now replace abstract modifier on open modifier Closes #1001
petertrr
reviewed
Jul 30, 2021
...-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter6/classes/AbstractClassesRule.kt
Outdated
Show resolved
Hide resolved
### What's done: * fixed bug in CLASS_SHOULD_NOT_BE_ABSTRACT * now replace abstract modifier on open modifier Closes #1001
petertrr
approved these changes
Jul 30, 2021
petertrr
requested changes
Jul 30, 2021
### What's done: * fixed bug in CLASS_SHOULD_NOT_BE_ABSTRACT * now replace abstract modifier on open modifier Closes #1001
petertrr
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Closes expect/actual removing abstract modifier #1001