Added rule to detect commented code #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Added CommentsRule with warning COMMENTED_OUT_CODE * Added tests * Fixed typo in all of custom rules
### What's done: * Updated README.md
orchestr7
requested changes
Jul 2, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/comments/CommentsRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/comments/CommentsRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/comments/CommentsRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/comments/CommentsRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter2/comments/CommentedCodeTest.kt
Show resolved
Hide resolved
…mmented-code # Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/FileNaming.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/IdentifierNaming.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/KdocComments.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/KdocFormatting.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/KdocMethods.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/PackageNaming.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/comments/HeaderCommentRule.kt
### What's done: * Fixes after merge
### What's done: * Refactoring * Additional test case
… into feature/rule-2.7-commented-code
petertrr
added a commit
that referenced
this pull request
Jul 31, 2020
* Added rule to detect commented code ### What's done: * Added CommentsRule with warning COMMENTED_OUT_CODE * Added tests * Fixed typo in all of custom rules *Updated README.md
aktsay6
added a commit
that referenced
this pull request
Nov 10, 2020
### What's done: * Fixed bugs * Smoke test #1 reworked
aktsay6
added a commit
that referenced
this pull request
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which rule and warnings did you add?
CommentsRule, Warnings.COMMENTED_OUT_CODE.
No fixers for now.
Actions checklist
Fixme