Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with year checking logic in copyright #688

Closed
petertrr opened this issue Jan 6, 2021 · 0 comments · Fixed by #693
Closed

Problems with year checking logic in copyright #688

petertrr opened this issue Jan 6, 2021 · 0 comments · Fixed by #693
Assignees
@aktsay6
Labels
bug Something isn't working

Comments

@petertrr
Copy link
Member

petertrr commented Jan 6, 2021

As referenced in #687:

there are some incorrect fixing cases:

  • Additional blank line is inserted after rearranging comments
  • Sometimes, when year is still not changed, there is an NPE somewhere in year checking logic.

Overall, it seems there are some cases that need to be fixed and covered with tests in year checking logic.

The changes from PR #687 can be reverted and tests executed to see exceptions and inconsistencies.
@petertrr petertrr added the bug Something isn't working label Jan 6, 2021
@aktsay6 aktsay6 self-assigned this Jan 11, 2021
aktsay6 added a commit that referenced this issue Jan 11, 2021
@aktsay6
bugfix/new-year-npe(#688)
882aa11 
### What's done:
  * Fixed NPE
@aktsay6 aktsay6 mentioned this issue Jan 11, 2021
Merged
aktsay6 added a commit that referenced this issue Jan 12, 2021
@aktsay6
bugfix/new-year-npe(#688)
51d78e7 
### What's done:
  * Added new warning
  * Updated Tests
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 12, 2021
@aktsay6
bugfix/bug-documentation-generation(#688)
bd7fb86 
### What's done:
  * Fixed bug
aktsay6 added a commit that referenced this issue Jan 13, 2021
@aktsay6
bugfix/new-year-npe(#688)
0f484ad 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 13, 2021
@aktsay6
bugfix/new-year-npe(#688)
d708fa5 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 13, 2021
@aktsay6
bugfix/new-year-npe(#688)
d65ddcc 
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Jan 14, 2021
@aktsay6
bugfix/new-year-npe(#688)
e59c2cf 
### What's done:
  * Fixed bug
aktsay6 added a commit that referenced this issue Jan 14, 2021
@aktsay6
bugfix/new-year-npe(#688)
6cc2ec6 
### What's done:
  * Fixed bug
aktsay6 added a commit that referenced this issue Jan 14, 2021
@aktsay6
bugfix/new-year-npe(#688)
781755b 
### What's done:
  * Fixed bug
aktsay6 added a commit that referenced this issue Jan 14, 2021
@aktsay6
Merge branch 'master' into bugfix/new-year-npe(#688)
bc4f045
aktsay6 added a commit that referenced this issue Jan 14, 2021
@aktsay6
Merge branch 'master' into bugfix/new-year-npe(#688)
78e28ec 
# Conflicts:
#	diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/comments/HeaderCommentRule.kt
aktsay6 added a commit that referenced this issue Jan 14, 2021
@aktsay6
Bugfix. Problems with year checking logic in copyright(#688) (#693)
8344d70 
* bugfix/new-year-npe(#688)

### What's done:
  * Added new warning
  * Updated Tests
  * Fixed bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aktsay6 aktsay6

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix.Problems with year checking logic in copyright(#688) saveourtool/diktat
2 participants
@petertrr @aktsay6