Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diktat 2.0 doesn't support configuration without configFile #1833

Closed
nulls opened this issue Nov 29, 2023 · 1 comment · Fixed by #1837
Closed

Diktat 2.0 doesn't support configuration without configFile #1833

nulls opened this issue Nov 29, 2023 · 1 comment · Fixed by #1837
Assignees
@nulls
Labels
bug Something isn't working regression
Milestone
2.0.0

Comments

@nulls
Copy link
Member

nulls commented Nov 29, 2023

Diktat 1.x supports configuration without config file with default properties for rules
@nulls nulls added bug Something isn't working regression labels Nov 29, 2023
@nulls nulls added this to the 2.0.0 milestone Nov 29, 2023
@nulls nulls self-assigned this Nov 29, 2023
@nulls
Copy link
Member Author

nulls commented Nov 29, 2023 •
edited
Loading

we can just use empty list of DiktatRuleConfig on Spotless level instead of changing the configuration loading

But still, plugins should support the same

@nulls nulls modified the milestones: 2.0.0, 2.1.0 Nov 29, 2023
nulls added a commit that referenced this issue Nov 29, 2023
@nulls
A dedicated module for configuration
f7dce8f 
### What's done:
- renamed 'diktat-common' to 'diktat-configuration'
- WIP

It closes #1833
@nulls nulls modified the milestones: 2.1.0, 2.0.0 Nov 30, 2023
@nulls nulls mentioned this issue Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nulls nulls

Labels
bug Something isn't working regression
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Support running diktat without configuration saveourtool/diktat
1 participant
@nulls