-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests after migration to ktlint 1.0 #1737
Comments
nulls
changed the title
Fix test after migration to ktlint 1.0
Fix tests after migration to ktlint 1.0
Sep 20, 2023
This was referenced Sep 21, 2023
nulls
added a commit
that referenced
this issue
Sep 21, 2023
### What's done: - add checking children to support case with comma before comment - reused ASTFactory It's part of #1737
nulls
added a commit
that referenced
this issue
Sep 21, 2023
### What's done: - removed a removing of moved ASTNode - reused ASTFactory It's part of #1737
nulls
added a commit
that referenced
this issue
Sep 22, 2023
### What's done: - creating BLOCK section in THEN section - reused ASTFactory It's part of #1737
Ignored tests:
|
nulls
added a commit
that referenced
this issue
Sep 22, 2023
### What's done: - added toDeterministic() for repeatable functions - fixed isFixMode and canBeAutoCorrected It's part of #1737
Merged
DrAlexD
added a commit
to DrAlexD/diktat
that referenced
this issue
Sep 25, 2023
### What's done: - Reworked `insertEmptyBlock()` function for adding empty braces blocks to conditions and `do-while` loop with empty bodies. - Added check for braces block existence to avoid duplicate braces block. - Added tests for conditions including tests for cases of `else if` and cases of empty `if` and `else` bodies. It's part of saveourtool#1737
DrAlexD
added a commit
that referenced
this issue
Sep 25, 2023
### What's done: - Reworked `insertEmptyBlock()` function for adding empty braces blocks to conditions and `do-while` loop with empty bodies. - Added check for braces block existence to avoid duplicate braces blocks. - Added tests for conditions including tests for cases of `else if` and cases of empty `if` and `else` bodies. It's part of #1737
DrAlexD
added a commit
to DrAlexD/diktat
that referenced
this issue
Sep 28, 2023
### What's done: - Added non-fixed warning `KDOC_EXTRA_PROPERTY` for case when `private` or `override` property has `@property` tag in class-KDoc. - Removed fixed warning `KDOC_NO_CONSTRUCTOR_PROPERTY` for case when `override` property hasn't `@property` tag in class-KDoc. - Added non-fixed warning `KDOC_NO_CONSTRUCTOR_PROPERTY_WITH_COMMENT` for case when `private` or `override` property has comment before. - Changed warning `KDOC_NO_CONSTRUCTOR_PROPERTY` to `KDOC_NO_CONSTRUCTOR_PROPERTY_WITH_COMMENT` for case when non-`private` and non-`override` property has comment before. - Added check is warning `KDOC_NO_CONSTRUCTOR_PROPERTY_WITH_COMMENT` fixable for case when non-`private` and non-`override` property has tags in KDoc-comment before. If it has = non-fixed. - Fixed case when text from comment before non-`private` and non-`override` property didn't append to the end of `@property` text in class-KDoc for that property. - Fixed case when `@property` text in class-KDoc didn't create for KDoc-comment before non-`private` and non-`override` property. - Fixed functions `removeWithWhiteSpace` and `removeChildMergingSurroundingWhitespaces` for additional handling KDoc-comments. - Reworked fix tests. Added fix test for case when `@property` tag exist in class-KDoc. - Added warning tests. It's part of saveourtool#1737
Merged
DrAlexD
added a commit
to DrAlexD/diktat
that referenced
this issue
Oct 2, 2023
- Fixed multiple generation of `@param` and `@throws` tags. It's part of saveourtool#1737
Merged
DrAlexD
added a commit
that referenced
this issue
Oct 3, 2023
- Fixed multiple generation of `@param` and `@throws` tags. It's part of #1737
DrAlexD
added a commit
to DrAlexD/diktat
that referenced
this issue
Oct 5, 2023
### What's done: - Fixed bug when fix-result of rule `LineLength` execution still contained `LineLength` warnings. To fix this, added loop that trying to fix `LineLength` warnings until warnings run out. - Added `unFix()` method realization inside `FunAndProperty` and `ValueArgumentList` classes to undo unnecessary fixes. - Fixed bug for case when long comment followed multiline property initialization. - Fixed and reworked several fix tests. It's part of saveourtool#1737
Merged
DrAlexD
added a commit
to DrAlexD/diktat
that referenced
this issue
Oct 5, 2023
### What's done: - Fixed bug related to string templates starting with new line. It's part of saveourtool#1737
Merged
DrAlexD
added a commit
that referenced
this issue
Oct 5, 2023
### What's done: - Fixed bug related to string templates starting with new line. It's part of #1737
DrAlexD
added a commit
that referenced
this issue
Oct 16, 2023
### What's done: - Changed warning `KDOC_NO_CONSTRUCTOR_PROPERTY` to `KDOC_NO_CONSTRUCTOR_PROPERTY_WITH_COMMENT` in some cases when property or parameter has comment before. - Added check is warning `KDOC_NO_CONSTRUCTOR_PROPERTY_WITH_COMMENT` fixable for case when property or parameter has any tags in KDoc-comment before. If it has = non-fixed. - Added configuration for `@param` tags creation: `isParamTagsForParameters` and `isParamTagsForPrivateProperties`. - Added fixed warnings `KDOC_NO_CONSTRUCTOR_PROPERTY` and `KDOC_NO_CONSTRUCTOR_PROPERTY_WITH_COMMENT` for cases when configuration options are on, and then `private` properties and parameters must have `@param` tags in class-KDoc. Additionally added logic for replacing incorrect tag with correct one regardless of whether configuration is enabled or not. - Added non-fixed warning `KDOC_EXTRA_PROPERTY` for redundant `@param` tags in class-KDoc. - Reworked fix tests. Added tests for cases when `@property` or `@param` tag exist in class-KDoc. - Added new warning tests. It's part of #1737
DrAlexD
added a commit
that referenced
this issue
Oct 16, 2023
### What's done: - Fixed bug when fix-result of rule `LineLength` execution still contained `LineLength` warnings. To fix this, added loop that trying to fix `LineLength` rule warnings until warnings run out. - Added `MAX_FIX_NUMBER` for limit on fixing to avoid infinite loop. If the limit is reached, then error message is displayed. - Added `unFix()` method realization inside `FunAndProperty` and `ValueArgumentList` classes to undo incorrect unnecessary fixes. - Fixed bug for case when long comment followed multiline property initialization. - Fixed and reworked several fix tests. It's part of #1737
nulls
added a commit
that referenced
this issue
Oct 26, 2023
### What's done: - fixed rule PACKAGE_NAME_MISSING It closes #1737
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All tests marked as
@Disabled("https://github.com/saveourtool/diktat/issues/1737")
Some of them can fail is due to multiply runs, another -- due to modification of AST tree (limitation of kotlin 1.9):
Possible solutions: pinterest/ktlint#2044
The text was updated successfully, but these errors were encountered: