Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usability of diktat-analysis: invalid override of rules #1146

Closed
orchestr7 opened this issue Dec 10, 2021 · 1 comment · Fixed by #1223
Closed

Usability of diktat-analysis: invalid override of rules #1146

orchestr7 opened this issue Dec 10, 2021 · 1 comment · Fixed by #1223
Assignees
@Arrgentum
Labels
bug Something isn't working
Milestone
1.0.4

Comments

@orchestr7
Copy link
Member

The following config would be treated as name: TRAILING_COMMA enabled: true

- name: TRAILING_COMMA
  enabled: true
  configuration:
    valueArgument: true
    valueParameter: true

# https://github.com/diktat-static-analysis/diKTat/issues/1106
- name: TRAILING_COMMA
  enabled: false
@orchestr7 orchestr7 added the bug Something isn't working label Dec 10, 2021
@orchestr7 orchestr7 self-assigned this Dec 10, 2021
@orchestr7 orchestr7 changed the title Usability of diktat-analysis Usability of diktat-analysis: invalid override Jan 27, 2022
@orchestr7 orchestr7 added this to the 1.0.3 milestone Jan 27, 2022
@orchestr7 orchestr7 modified the milestones: 1.0.3, 1.0.4 Feb 11, 2022
@orchestr7 orchestr7 assigned Arrgentum and unassigned orchestr7 Feb 22, 2022
@orchestr7
Copy link
Member Author

https://github.com/charleskorn/kaml

open class RulesConfigReader(override val classLoader: ClassLoader) : JsonResourceConfigReader<List<RulesConfig>>() {
    private val yamlSerializer by lazy { Yaml(configuration = YamlConfiguration(strictMode = true)) }

Arrgentum pushed a commit that referenced this issue Mar 4, 2022
Usability of diktat-analysis: invalid override
b1b7fb8 
### What's done:
- Corrected the order of inclusion of rules

(#1146)
Arrgentum pushed a commit that referenced this issue Mar 4, 2022
Usability of diktat-analysis: invalid override
dca07ba 
### What's done:
- Corrected the order of inclusion of rules

(#1146)
@Arrgentum Arrgentum mentioned this issue Mar 4, 2022
Merged
Arrgentum pushed a commit that referenced this issue Mar 4, 2022
Usability of diktat-analysis: invalid override
dbb385f 
### What's done:
- Corrected the order of inclusion of rules

(#1146)
@orchestr7 orchestr7 changed the title Usability of diktat-analysis: invalid override Usability of diktat-analysis: invalid override of rules Mar 4, 2022
Arrgentum added a commit that referenced this issue Mar 11, 2022
@Arrgentum
Bugfix/invalid override enabled (#1223)
970f316 
* Usability of diktat-analysis: invalid override

### What's done:
- Corrected the order of inclusion of rules

(#1146)

Co-authored-by: Alexey Votintsev <alexeyvotintsev.yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arrgentum Arrgentum

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.4
Development

Successfully merging a pull request may close this issue.

Bugfix/invalid override enabled saveourtool/diktat
2 participants
@orchestr7 @Arrgentum