-
Notifications
You must be signed in to change notification settings - Fork 39
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Keep return type when converting function to function with expression…
… body (#1017) ### What's done: * fixed bug in WRONG_NEWLINES * now don't remove return type Closes #965
- Loading branch information
1 parent
841ef74
commit 88f5d64
Showing
8 changed files
with
35 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 6 additions & 4 deletions
10
diktat-rules/src/test/resources/test/paragraph3/newlines/ExpressionBodyExpected.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,17 @@ | ||
package test.paragraph3.newlines | ||
|
||
fun foo() = "lorem ipsum" | ||
fun foo(): String = "lorem ipsum" | ||
|
||
fun foo() = "lorem ipsum" | ||
fun foo():String = "lorem ipsum" | ||
|
||
fun foo() = "lorem ipsum" | ||
fun foo() : String = "lorem ipsum" | ||
|
||
fun recFoo(): String = "lorem " + recFoo() | ||
|
||
fun recFoo():String = "lorem " + recFoo() | ||
|
||
fun recFoo(): String = "lorem " + recFoo() | ||
|
||
fun foo() = "lorem ipsum" | ||
fun foo() = "lorem ipsum" | ||
|
||
fun foo() = println("Logging") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
diktat-rules/src/test/resources/test/paragraph3/newlines/OneLineFunctionExpected.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
package test.paragraph3.newlines | ||
|
||
class Example { | ||
fun doubleA() = 2 * a | ||
fun doubleA() = 2 * a | ||
fun doubleA(): Int = 2 * a | ||
fun doubleA(): Int = 2 * a | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88f5d64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to retrieve PDD puzzles from the code base and submit them to GitHub. If you think that it's a bug on our side, please submit it to yegor256/0pdd:
Please, copy and paste this stack trace to GitHub: