Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt Format Not Changing #10

Closed
vitorpena opened this issue Dec 17, 2022 · 2 comments
Closed

Alt Format Not Changing #10

vitorpena opened this issue Dec 17, 2022 · 2 comments

Comments

@vitorpena
Copy link

Hi,

I noticed that the alt format wasn't being changed, so I tinkered a bit and explored that we needed to tweak a couple of lines of code.

In file: flatpickr.blade.php please add: "altInput" => $isAltInput(), after line 3.

In file dist/datepicker.js please change line 16 to "altFormat: attribs.altFormat,"

That should do it. Thanks for making this component I really appreciate it!
@coolsam726
Copy link
Contributor

Hi @vitorpena,
Thank you for taking your time to explore the solution to your issue. Could you kindly make the changes in a fork and submit a Pull Request? I would be glad to merge it.

Thanks!

coolsam726 added a commit that referenced this issue Jul 27, 2023
@coolsam726
Merge pull request #27 from savannabits/2.x-dev
f680fbe 
## 2.x dev - Full Re-Write of the package, with bug fixes:

### Improvements and Fixes:
1. Dark mode is now enabled on the fly for the FilamentPHP admin panel.
2. The package can now be used in standalone forms outside the filament admin panel. Fixes #1, #2, #6, #23
3. Almost all of Flatpickr's native configuration is now supported out of the box through a fluent interface. Fixes #10, #11, #24
3. Alpine.js component is now loading lazily using async-alpine
@coolsam726
Copy link
Contributor

Fixed in #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coolsam726 @vitorpena