fix: Should download artifacts when no retries #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The root cause is that when setting retries and downloading artifacts simultaneously, the code determines whether to proceed with the download by checking
AllAttemptsand whether it's the last attempt (attempts < total retries).However, if the job doesn’t run out of retries (e.g., if the first job has passed or the job passes threshold before hitting the retry limit), the number of attempts is smaller than the total retries, leading to the download being skipped.
To fix this issue, I updated the download function as we've known if the job is the last attempt.
This solves #939 and #938