Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Update npm.strictSSL behavior #935

Merged
merged 14 commits into from
Aug 15, 2024
Merged

fix!: Update npm.strictSSL behavior #935

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ea1a413
fix: Unify npm.strictSSL behavior
tianfeng92 Aug 12, 2024
4ab9910
revise message
tianfeng92 Aug 12, 2024
f028371
Apply suggestions from code review
tianfeng92 Aug 14, 2024
fe6e2c7
apply suggestion
tianfeng92 Aug 14, 2024
18e0ea7
fix linter
tianfeng92 Aug 14, 2024
a8d53a3
Update internal/http/proxy.go
tianfeng92 Aug 14, 2024
6a9ce60
Update internal/cmd/docker/push.go
tianfeng92 Aug 14, 2024
91b76a4
set strictSSL default value to true
tianfeng92 Aug 14, 2024
6a8bf35
assign nil value to strictSSL when only using flags
tianfeng92 Aug 15, 2024
a44f607
fix go releaser
tianfeng92 Aug 15, 2024
e48d68c
fix goreleaser again!
tianfeng92 Aug 15, 2024
6671fd6
use separate flags
tianfeng92 Aug 15, 2024
5926567
Update internal/cmd/run/cypress.go
tianfeng92 Aug 15, 2024
1745205
apply suggestions
tianfeng92 Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/cmd/run/cypress.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,10 @@ func NewCypressCmd() *cobra.Command {
sc.String("npm.registry", "npm::registry", "", "Specify the npm registry URL")
sc.StringToString("npm.packages", "npm::packages", map[string]string{}, "Specify npm packages that are required to run tests")
sc.StringSlice("npm.dependencies", "npm::dependencies", []string{}, "Specify local npm dependencies for saucectl to upload. These dependencies must already be installed in the local node_modules directory.")
sc.Bool("npm.strictSSL", "npm::strictSSL", true, "Whether or not to do SSL key validation when making requests to the registry via https")
sc.Bool("npm.strictSSL", "npm::strictSSL", false, "Whether or not to do SSL key validation when making requests to the registry via https (default: false)")
tianfeng92 marked this conversation as resolved.
Show resolved Hide resolved

// Deprecated flags
_ = sc.Fset.MarkDeprecated("npm.registry", "please set the npm registries field in the Sauce configuration file")

return cmd
}
Expand Down
4 changes: 3 additions & 1 deletion internal/cmd/run/playwright.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,10 @@ func NewPlaywrightCmd() *cobra.Command {
sc.String("npm.registry", "npm::registry", "", "Specify the npm registry URL")
sc.StringToString("npm.packages", "npm::packages", map[string]string{}, "Specify npm packages that are required to run tests")
sc.StringSlice("npm.dependencies", "npm::dependencies", []string{}, "Specify local npm dependencies for saucectl to upload. These dependencies must already be installed in the local node_modules directory.")
sc.Bool("npm.strictSSL", "npm::strictSSL", true, "Whether or not to do SSL key validation when making requests to the registry via https")
sc.Bool("npm.strictSSL", "npm::strictSSL", false, "Whether or not to do SSL key validation when making requests to the registry via https (default: false)")

// Deprecated flags
_ = sc.Fset.MarkDeprecated("npm.registry", "please set the npm registries field in the Sauce configuration file")
return cmd
}

Expand Down
5 changes: 4 additions & 1 deletion internal/cmd/run/testcafe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,14 @@ func NewTestcafeCmd() *cobra.Command {
sc.String("npm.registry", "npm::registry", "", "Specify the npm registry URL")
sc.StringToString("npm.packages", "npm::packages", map[string]string{}, "Specify npm packages that are required to run tests")
sc.StringSlice("npm.dependencies", "npm::dependencies", []string{}, "Specify local npm dependencies for saucectl to upload. These dependencies must already be installed in the local node_modules directory.")
sc.Bool("npm.strictSSL", "npm::strictSSL", true, "Whether or not to do SSL key validation when making requests to the registry via https")
sc.Bool("npm.strictSSL", "npm::strictSSL", false, "Whether or not to do SSL key validation when making requests to the registry via https (default: false)")

// Simulators
f.Var(&lflags.Simulator, "simulator", "Specifies the simulator to use for testing")

// Deprecated flags
_ = sc.Fset.MarkDeprecated("npm.registry", "please set the npm registries field in the Sauce configuration file")

return cmd
}

Expand Down