build: Use Go 1.22 #909
Merged
build: Use Go 1.22 #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexplischke
previously approved these changes
May 16, 2024
alexplischke
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Go 1.22.
Notes:
Our pipeline failed because it didn't meet the test coverage threshold, as detailed here: GitHub Actions Log.
This issue arose due to changes in Go 1.22, which updated how test coverage reports are generated. Previously, Go did not include packages without test files in coverage calculations. With Go 1.22, these packages are now counted, each showing 0% coverage, causing our test coverage in
saucectlto drop from around 43% to 34%. While this provides a more realistic measure of coverage.Talked with @alexplischke , as we've discussed repeatedly, test coverage is merely a numerical metric and does not accurately reflect the true quality of the product. Therefore, we should consider removing the coverage threshold.