Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: init region requirement for no-prompt mode #868

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: init region requirement for no-prompt mode #868

merged 1 commit into from
Dec 8, 2023

Conversation

alexplischke
Copy link
Contributor

Proposed changes

Ensure that the proper error message is returned when the region is not set.

Before:

❯ saucectl init playwright --no-prompt
4 errors occured:
- no playwright version specified
- no platform name specified
- no browser name specified
- Get "/v2/testcomposer/frameworks?frameworkName=playwright": unsupported protocol scheme ""

After:

❯ saucectl init playwright --no-prompt
12:40:58 ERR failed to execute init command error="no sauce region set"

@alexplischke alexplischke added the bug Something isn't working label Dec 8, 2023
@alexplischke alexplischke marked this pull request as ready for review December 8, 2023 20:50
@alexplischke alexplischke requested a review from a team as a code owner December 8, 2023 20:50
@alexplischke alexplischke merged commit 3af4169 into main Dec 8, 2023
20 checks passed
@alexplischke alexplischke deleted the DEVX-2684-region branch December 8, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianfeng92 tianfeng92 tianfeng92 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexplischke @tianfeng92