Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: app storage filename references for xcuitest simulators #859

Merged
merged 3 commits into from
Nov 29, 2023
Merged

fix: app storage filename references for xcuitest simulators #859

merged 3 commits into from
Nov 29, 2023

Conversation

alexplischke
Copy link
Contributor

Proposed changes

Makes app storage references work when using filenames + xcuitest simulators.

Also:

  • minor refactor that aligns the lingo between the functions IsStorageReference and NormalizeStorageReference.

@alexplischke alexplischke added bug Something isn't working xcuitest Pull requests that affect xcuitest integration labels Nov 29, 2023
@alexplischke alexplischke marked this pull request as ready for review November 29, 2023 01:00
@alexplischke alexplischke requested a review from a team as a code owner November 29, 2023 01:00
@alexplischke alexplischke merged commit 09a2a7f into main Nov 29, 2023
18 checks passed
@alexplischke alexplischke deleted the DEVX-2683 branch November 29, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhan83 mhan83 mhan83 approved these changes

@tianfeng92 tianfeng92 tianfeng92 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working xcuitest Pull requests that affect xcuitest integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexplischke @mhan83 @tianfeng92