Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add buildURL in JSON report #848

Merged
merged 9 commits into from
Nov 2, 2023
Merged

feat: Add buildURL in JSON report #848

merged 9 commits into from
Nov 2, 2023

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Nov 1, 2023

Proposed changes

Add buildURL in each job's details.

The JSON report will like

[
  {
    "name": "saucy barista - specify device by id",
    "duration": 15369633708,
    "startTime": "2023-10-31T20:19:54.975575-07:00",
    "endTime": "2023-10-31T20:20:10.345318-07:00",
    "status": "failed",
    "platform": "Android",
    "deviceName": "LG_Q6_real_us",
    "url": "https://app.saucelabs.com/tests/1f2f60dce5314e10b422e0d87bf2a465",
    "origin": "sauce",
    "buildURL": "https://app.saucelabs.com/builds/rdc/f2157d6dd70e3ae1b7c265d417a785ae"
  },
  {
    "name": "saucy barista - test size",
    "duration": 57726330417,
    "startTime": "2023-10-31T20:19:54.976777-07:00",
    "endTime": "2023-10-31T20:20:52.703524-07:00",
    "status": "passed",
    "platform": "Android 11.0",
    "deviceName": "Android GoogleApi Emulator",
    "url": "https://app.saucelabs.com/tests/b2133c11194b4c7989f0cf11afbbfa04",
    "origin": "sauce",
    "buildURL": "https://app.saucelabs.com/builds/vdc/0a394db12e1831ce9aa86e41c2bb66e7"
  }
]

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

@tianfeng92 tianfeng92 added the enhancement New feature or request label Nov 1, 2023
@tianfeng92 tianfeng92 requested a review from a team as a code owner November 1, 2023 03:46
internal/report/json/json.go Outdated Show resolved Hide resolved
internal/report/json/json.go Outdated Show resolved Hide resolved
internal/saucecloud/cloud.go Outdated Show resolved Hide resolved
internal/saucecloud/cloud.go Outdated Show resolved Hide resolved
tianfeng92 and others added 2 commits November 1, 2023 16:57
Co-authored-by: Alex Plischke <alex.plischke@saucelabs.com>
@tianfeng92 tianfeng92 merged commit 5a44562 into main Nov 2, 2023
18 checks passed
@tianfeng92 tianfeng92 deleted the DEVX-2558 branch November 2, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants