Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable env vars for xcuitest #834

Merged
merged 6 commits into from
Sep 14, 2023
Merged

feat: Enable env vars for xcuitest #834

merged 6 commits into from
Sep 14, 2023

Conversation

mhan83
Copy link
Contributor

@mhan83 mhan83 commented Sep 14, 2023

Proposed changes

Add support for defining env vars for xcuitest.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

@mhan83 mhan83 requested a review from a team as a code owner September 14, 2023 17:15
alexplischke
alexplischke previously approved these changes Sep 14, 2023
View reviewed changes
@mhan83 mhan83 added xcuitest Pull requests that affect xcuitest integration enhancement New feature or request labels Sep 14, 2023
tianfeng92
tianfeng92 previously approved these changes Sep 14, 2023
View reviewed changes
@mhan83 mhan83 dismissed stale reviews from tianfeng92 and alexplischke via 38b5590 September 14, 2023 17:54
@mhan83 mhan83 merged commit b6f7481 into main Sep 14, 2023
18 checks passed
@mhan83 mhan83 deleted the devx-2527 branch September 14, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexplischke alexplischke alexplischke approved these changes

@tianfeng92 tianfeng92 tianfeng92 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request xcuitest Pull requests that affect xcuitest integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhan83 @alexplischke @tianfeng92