Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add additional testOptions for xcuitest #819

Merged
merged 13 commits into from
Aug 11, 2023
Merged

feat: Add additional testOptions for xcuitest #819

merged 13 commits into from
Aug 11, 2023

Conversation

mhan83
Copy link
Contributor

@mhan83 mhan83 commented Aug 10, 2023

Proposed changes

Add additional testOptions for xcuitest on simulators.

SauceCTL Test option input xcodebuild command Notes
testTimeoutsEnabled: "Yes|No" -test-timeouts-enabled [YES | NO] By default there is no timeout, if enabled, then the timeout is 600 seconds. This can be changed by adding the defaultTestExecutionTimeAllowance value. See also https://developer.apple.com/documentation/xctest/xctestcase/3526064-executiontimeallowance
defaultTestExecutionTimeAllowance: 200 //in seconds -default-test-execution-time-allowance seconds The default execution time an individual test is given to execute if test timeouts are enabled. See also https://developer.apple.com/documentation/xctest/xctestcase/3526064-executiontimeallowance
maximumTestExecutionTimeAllowance 300 // in seconds -maximum-test-execution-time-allowance seconds The maximum execution time an individual test is given to execute, regardless of the test's preferred allowance. See also https://developer.apple.com/documentation/xctest/xctestcase/3526064-executiontimeallowance
testLanguage language -testLanguage language Specifies ISO 639-1 language during testing. See https://www.loc.gov/standards/iso639-2/php/code_list.php
testRegion region -testRegion region Specifies ISO 3166-1 region during testing, see also https://www.iso.org/obp/ui/#search

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

Because reasons, TestOptions needs to be converted to a map[string]interface{} type. I opted to use reflection to do it for easier maintainability, but I could be easily convinced to not use reflection...

@mhan83 mhan83 added enhancement New feature or request xcuitest Pull requests that affect xcuitest integration labels Aug 10, 2023
@mhan83 mhan83 requested a review from a team as a code owner August 10, 2023 17:43
api/v1alpha/framework/xcuitest.schema.json Outdated Show resolved Hide resolved
internal/xcuitest/config.go Outdated Show resolved Hide resolved
mhan83 and others added 4 commits August 10, 2023 12:43
@mhan83 mhan83 merged commit 3fd3738 into main Aug 11, 2023
18 checks passed
@mhan83 mhan83 deleted the devx-2472 branch August 11, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request xcuitest Pull requests that affect xcuitest integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants